Skip to content

GH-6372: Expose client request metrics. #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chickenchickenlove wants to merge 13 commits into
base: main
Choose a base branch
from

Remove useless code.

bee21ea
Select commit
Loading
Failed to load commit list.
Open

GH-6372: Expose client request metrics. #6502

Remove useless code.
bee21ea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2026 in 0s

74.25% (-0.22%) compared to 8150425

View this Pull Request on Codecov

74.25% (-0.22%) compared to 8150425

Details

Codecov Report

❌ Patch coverage is 75.21368% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.25%. Comparing base (8150425) to head (bee21ea).
⚠️ Report is 326 commits behind head on main.

Files with missing lines Patch % Lines
...rp/armeria/client/metric/ClientRequestMetrics.java 72.46% 9 Missing and 10 partials ⚠️
...ent/metric/NoopClientRequestLifecycleListener.java 54.54% 5 Missing ⚠️
...com/linecorp/armeria/client/HttpClientFactory.java 57.14% 3 Missing ⚠️
...lient/logging/DefaultClientRequestLogListener.java 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6502      +/-   ##
============================================
- Coverage     74.46%   74.25%   -0.22%     
- Complexity    22234    23573    +1339     
============================================
  Files          1963     2120     +157     
  Lines         82437    88359    +5922     
  Branches      10764    11586     +822     
============================================
+ Hits          61385    65608    +4223     
- Misses        15918    17209    +1291     
- Partials       5134     5542     +408

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov