Skip to content

Expose Athenz TokenClient as public API #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyunw9 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Expose Athenz TokenClient as public API #6460

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08772b8
feat : Make TokenClient public
hyunw9 Oct 26, 2025
3a1be43
feat : Add final
hyunw9 Oct 26, 2025
56e7e97
Merge branch 'main' into feature/expose-athenz-api-public
ikhoon Nov 4, 2025
d56fc5b
feat : Release public keyword
hyunw9 Nov 18, 2025
c913467
feat : [athenz] Add factory method to TokenClient
hyunw9 Nov 18, 2025
4205241
refactor : Rename ImmutableRoleNames
hyunw9 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion athenz/src/main/java/com/linecorp/armeria/client/athenz/AccessTokenClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import com.linecorp.armeria.common.auth.oauth2.GrantedOAuth2AccessToken;
import com.linecorp.armeria.common.util.Exceptions;

final class AccessTokenClient implements TokenClient {
public final class AccessTokenClient implements TokenClient {
Copy link
Copy Markdown
Contributor

@ikhoon ikhoon Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the public keyword doesn’t necessarily mean the user can use it right away.

  • TokenClient client is still in private.
  • There are no public constructors or builder methods to create AccessTokenClient or `RoleTokenClient.

Suggestion:

  • Should we only make TokenClient public class? Let's keep AccessTokenClient and RoleTokenClient package-private.
  • Override as method to obtain an instance of TokenClient in AthenzClient?

Copy link
Copy Markdown
Contributor

@ikhoon ikhoon Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that overriding as is not a feasible solution as AthenzClient.newDecorator() returns a function. Instead, let's add a factory method TokenClient.

public interface TokenClient {

    TokenClient of(....) {
        if (tokenType.isRoleToken()) {
            return new RoleTokenClient(ztsBaseClient, domainName, roleNames, refreshBefore);
        } else {
            return new AccessTokenClient(ztsBaseClient, domainName, roleNames, refreshBefore);
        }
    }

Copy link
Copy Markdown
Contributor Author

@hyunw9 hyunw9 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review ! I completely misunderstood.


private final AtomicBoolean tlsKeyPairUpdated = new AtomicBoolean();

Expand Down
2 changes: 1 addition & 1 deletion athenz/src/main/java/com/linecorp/armeria/client/athenz/RoleTokenClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import com.linecorp.armeria.common.util.Exceptions;
import com.linecorp.armeria.common.util.UnmodifiableFuture;

final class RoleTokenClient implements TokenClient {
public final class RoleTokenClient implements TokenClient {

static final Joiner ROLE_JOINER = Joiner.on(",");

Expand Down
Loading