add support for is_loaded to allow conditional loading#106
Open
apollo13 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 401 410 +9
Branches 5 5
=========================================
+ Hits 401 410 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
apollo13
force-pushed
the
fb-is-loaded
branch
2 times, most recently
from
July 17, 2026 10:20
9f65b80 to
5316514
Compare
apollo13
commented
Jul 17, 2026
| dependencies = [ | ||
| "pydantic-settings>=2.13", | ||
| "pydantic>=2.7", | ||
| "pydantic>=2.12", |
Contributor
Author
There was a problem hiding this comment.
Sadly this is required (I tried all versions below) since we seem to be running into a pydantic bug otherwise. That said if people need to use old pydantic they can pin goodconf (also this is not like the 1 -> 2 migration)
Member
|
lgtm 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using
config.load()in my Django settings.py but in some cases I want to "preload" them from somewhere else. With this flag I could skip loading.