-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chainntnfs: add a pkscript notifier stream #10807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hieblmi
wants to merge
10
commits into
lightningnetwork:master
Choose a base branch
from
hieblmi:address-notifier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bf664ad
chainntnfs: add pkScript notifier engine
hieblmi 349173f
chainntnfs: wire pkScript notifier backends
hieblmi be4fbe6
chainrpc: add pkScript notifier stream
hieblmi 80f0a11
itest: cover pkScript notifier flows
hieblmi 9cfb295
docs: describe pkScript notifier
hieblmi c8787c0
docs: add pkScript notifier example
hieblmi 068f0e3
docs: add pkScript notifier reorg example
hieblmi 5929c15
docs: update pkScript notifier release notes
hieblmi edcddd4
docs: link pkscript notifier release notes
hieblmi 5aa4f31
test: stabilize pkscript notifier checks
hieblmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's significant code duplication for the historical pkScript dispatch logic across
bitcoindnotify,btcdnotify, andneutrinonotifybackends. The functionsqueueHistoricalPkScriptDispatch,reserveHistoricalPkScriptDispatchSlot,releaseHistoricalPkScriptDispatchSlot,queueReservedHistoricalPkScriptDispatch, andhistoricalPkScriptDispatcherare nearly identical in all three files.Consider refactoring this logic into a shared helper struct that can be embedded by each notifier. This would improve maintainability and reduce redundancy.