build: bump runc to v1.2.8#10791
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a security-focused dependency update, primarily targeting the Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
🟠 PR Severity: HIGH
🟠 High (4 files)
🟡 Medium (2 files)
🟢 Low (1 file)
AnalysisThis PR updates Go module dependencies, primarily for the The changes are dependency/lockfile updates (go.mod/go.sum), which are typically low-risk in isolation, but dependency changes to the No bump rules triggered: 7 files (threshold: >20), 83 lines changed (threshold: >500), and no multiple distinct critical packages touched. To override, add a |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, primarily runc to v1.2.8 to address security vulnerabilities. Other updates include logrus, go-systemd, and urfave/cli. Feedback was provided questioning the validity of the 2025 CVE years mentioned in the release notes.
| ## Code Health | ||
|
|
||
| * Updated `github.com/opencontainers/runc` to `v1.2.8`, which includes | ||
| fixes for CVE-2025-31133, CVE-2025-52565, and CVE-2025-52881. |
|
@rloomba, remember to re-request review from reviewers when ready |
Change Description
Bump
github.com/opencontainers/runctov1.2.8in theroot,sqldb, andsqldb/v2modules.This updates
runcto the patched version for the following CVEs:Steps to Test
Run the following compile-only checks:
Pull Request Checklist
Testing
Code Style and Documentation
fight bot spam.
and lines wrap at 80.