-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[WIP] MPP record support for QueryRoutes/SendToRoute (#9952) #10770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # LND #9952 Implementation Guide | ||
|
|
||
| ## Changes Needed | ||
|
|
||
| ### 1. lnrpc/routerrpc/router.proto | ||
| Add to `QueryRoutesRequest`: | ||
| ```protobuf | ||
| bytes payment_addr = 15; | ||
| ``` | ||
|
|
||
| Add to `SendToRouteRequest`: | ||
| ```protobuf | ||
| MPPRecord mpp_record = 3; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ``` | ||
|
|
||
| ### 2. lnrpc/lightning.proto | ||
| Ensure MPPRecord is defined: | ||
| ```protobuf | ||
| message MPPRecord { | ||
| bytes payment_addr = 1; | ||
| uint64 total_amt_msat = 2; | ||
| } | ||
|
Comment on lines
+19
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| ``` | ||
|
|
||
| ### 3. routing/router.go | ||
| Update `QueryRoutes` to include MPP record. | ||
|
|
||
| ### 4. cmd/lncli/commands.go | ||
| Add flags for payment_addr. | ||
|
|
||
| ## Generate & Test | ||
| ```bash | ||
| make rpc | ||
| make check | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field number 15 is already occupied by
last_hop_pubkeyinQueryRoutesRequest(seelnrpc/lightning.protoline 3327). Additionally,QueryRoutesRequestis defined inlnrpc/lightning.proto, notlnrpc/routerrpc/router.proto. Please use the next available field number, which is 21, in the correct file.