Skip to content

Add BOLT12 support to LSPS2 via custom Router implementation #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnull wants to merge 22 commits into
base: main
Choose a base branch
from

Derive `Hash` for `OfferId`

4342483
Select commit
Loading
Failed to load commit list.
Open

Add BOLT12 support to LSPS2 via custom Router implementation #4463

Derive `Hash` for `OfferId`
4342483
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2026 in 0s

87.13% (+0.04%) compared to 2313bd5

View this Pull Request on Codecov

87.13% (+0.04%) compared to 2313bd5

Details

Codecov Report

❌ Patch coverage is 88.38174% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.13%. Comparing base (2313bd5) to head (4342483).
⚠️ Report is 169 commits behind head on main.

Files with missing lines Patch % Lines
lightning-liquidity/src/lsps2/router.rs 93.39% 27 Missing ⚠️
lightning/src/ln/channelmanager.rs 32.00% 16 Missing and 1 partial ⚠️
lightning/src/events/mod.rs 33.33% 5 Missing and 1 partial ⚠️
lightning/src/offers/flow.rs 66.66% 2 Missing and 1 partial ⚠️
lightning/src/onion_message/messenger.rs 86.66% 2 Missing ⚠️
lightning/src/util/test_utils.rs 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4463      +/-   ##
==========================================
+ Coverage   87.08%   87.13%   +0.04%     
==========================================
  Files         161      162       +1     
  Lines      109255   109707     +452     
  Branches   109255   109707     +452     
==========================================
+ Hits        95147    95589     +442     
- Misses      11627    11632       +5     
- Partials     2481     2486       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov