Skip to content

[RFC] Add BOLT 12 payer proof primitives #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincenzopalazzo wants to merge 21 commits into
base: main
Choose a base branch
from

fixup! feat(offers): add BOLT 12 payer proof primitives

da423f0
Select commit
Loading
Failed to load commit list.
Open

[RFC] Add BOLT 12 payer proof primitives #4297

fixup! feat(offers): add BOLT 12 payer proof primitives
da423f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 14, 2026 in 1s

86.48% (+0.07%) compared to b8118e3

View this Pull Request on Codecov

86.48% (+0.07%) compared to b8118e3

Details

Codecov Report

❌ Patch coverage is 90.15317% with 180 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.48%. Comparing base (b8118e3) to head (da423f0).

Files with missing lines Patch % Lines
lightning/src/offers/payer_proof.rs 87.29% 134 Missing and 29 partials ⚠️
lightning/src/offers/merkle.rs 96.96% 7 Missing and 4 partials ⚠️
lightning/src/ln/channelmanager.rs 90.90% 2 Missing and 1 partial ⚠️
lightning/src/ln/outbound_payment.rs 97.72% 1 Missing ⚠️
lightning/src/offers/invoice.rs 97.91% 1 Missing ⚠️
lightning/src/offers/signer.rs 97.29% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4297      +/-   ##
==========================================
+ Coverage   86.40%   86.48%   +0.07%     
==========================================
  Files         158      159       +1     
  Lines      109293   111069    +1776     
  Branches   109293   111069    +1776     
==========================================
+ Hits        94439    96058    +1619     
- Misses      12309    12427     +118     
- Partials     2545     2584      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov