feat: remove getWalletBalances action for deprecated /balances endpoint#431
Open
chybisov wants to merge 1 commit into
Open
feat: remove getWalletBalances action for deprecated /balances endpoint#431chybisov wants to merge 1 commit into
chybisov wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 73bd3c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
(please link)
Why was it implemented this way?
The
/wallets/{address}/balancesAPI endpoint is being deprecated, so thegetWalletBalancesaction (its only consumer in the SDK) is removed along with its export, client-method wrapper, and unit spec. Token balances remain fully covered by the RPC-drivengetTokenBalance/getTokenBalances/getTokenBalancesByChainfamily, which is untouched.Benchmarked the RPC path to confirm it can carry the full load without the endpoint: 1000 Ethereum tokens resolve in ~440 ms via a single HTTP request (viem multicall batches them into 36
eth_calls), with all spot-checked balances matching an independent RPC read at the pinned block. A 5-chain × ~1000-token sweep completes in ~2.1 s with zero failed requests, so no extra chunking configuration is needed.Ships as a minor bump per team decision; the changeset calls out the removal so integrators see it in release notes.
Visual showcase (Screenshots or Videos)
N/A — API surface removal.
Checklist before requesting a review