Skip to content

feat: remove getWalletBalances action for deprecated /balances endpoint#431

Open
chybisov wants to merge 1 commit into
mainfrom
remove-wallet-balances
Open

feat: remove getWalletBalances action for deprecated /balances endpoint#431
chybisov wants to merge 1 commit into
mainfrom
remove-wallet-balances

Conversation

@chybisov

Copy link
Copy Markdown
Member

Which Linear task is linked to this PR?

(please link)

Why was it implemented this way?

The /wallets/{address}/balances API endpoint is being deprecated, so the getWalletBalances action (its only consumer in the SDK) is removed along with its export, client-method wrapper, and unit spec. Token balances remain fully covered by the RPC-driven getTokenBalance/getTokenBalances/getTokenBalancesByChain family, which is untouched.

Benchmarked the RPC path to confirm it can carry the full load without the endpoint: 1000 Ethereum tokens resolve in ~440 ms via a single HTTP request (viem multicall batches them into 36 eth_calls), with all spot-checked balances matching an independent RPC read at the pinned block. A 5-chain × ~1000-token sweep completes in ~2.1 s with zero failed requests, so no extra chunking configuration is needed.

Ships as a minor bump per team decision; the changeset calls out the removal so integrators see it in release notes.

Visual showcase (Screenshots or Videos)

N/A — API surface removal.

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.
  • If this PR modifies the SDK API or adds new features that require documentation, I have updated the documentation in the public-docs repository.

@changeset-bot

changeset-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 73bd3c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@lifi/sdk Minor
@lifi/sdk-provider-bitcoin Patch
@lifi/sdk-provider-ethereum Patch
@lifi/sdk-provider-solana Patch
@lifi/sdk-provider-sui Patch
@lifi/sdk-provider-tron Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant