Skip to content

Fix token balances chain id validation #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsamtrum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix token balances chain id validation #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/sdk/src/actions/getTokenBalancesByChain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ export async function getTokenBalancesByChain(
if (invalidTokens.length) {
throw new ValidationError('Invalid tokens passed.')
}
const chainIds = Object.keys(tokensByChain).map((chainIdStr) => {
if (!/^\d+$/u.test(chainIdStr)) {
throw new ValidationError('Invalid chainId passed.')
}
return Number.parseInt(chainIdStr, 10)
})

const provider = client.providers.find((provider) =>
provider.isAddress(walletAddress)
Expand All @@ -48,8 +54,7 @@ export async function getTokenBalancesByChain(
[chainId: number]: TokenAmount[] | TokenAmountExtended[]
} = {}
const tokenAmountsSettled = await Promise.allSettled(
Object.keys(tokensByChain).map(async (chainIdStr) => {
const chainId = Number.parseInt(chainIdStr, 10)
chainIds.map(async (chainId) => {
const chain = await client.getChainById(chainId)
if (provider.type === chain.chainType) {
const tokenAmounts = await provider.getBalance(
Expand Down
8 changes: 8 additions & 0 deletions packages/sdk/src/actions/getTokenBalancesByChain.unit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ describe('getTokenBalancesByChain', () => {
).rejects.toThrow('Invalid tokens passed.')
})

it('should throw Error because of an invalid chain id', async () => {
await expect(
getTokenBalancesByChain(client, SOME_WALLET_ADDRESS, {
['1abc' as unknown as ChainId]: [SOME_TOKEN],
})
).rejects.toThrow('Invalid chainId passed.')
})

it('should return empty token list as it is', async () => {
mockedGetTokenBalancesForChains.mockReturnValue(Promise.resolve([]))

Expand Down