Skip to content

docs(skills): remind to allow-list new deployer on Sophon in rotate-deployer-wallet#2070

Open
gvladika wants to merge 1 commit into
mainfrom
feat/exsc-648-sophon-allowlist-reminder
Open

docs(skills): remind to allow-list new deployer on Sophon in rotate-deployer-wallet#2070
gvladika wants to merge 1 commit into
mainfrom
feat/exsc-648-sophon-allowlist-reminder

Conversation

@gvladika

Copy link
Copy Markdown
Contributor

Which Linear task belongs to this PR?

Fixes EXSC-648

Why did I implement it this way?

During the LayerSwapFacet zkSync-family rollout the Sophon deploy failed with contract deployer address … is not in the allow list. Sophon gates contract deployment behind a per-EOA allow-list; the recently rotated deployer wasn't on it (the old deployer was — that's why Sophon already hosts our diamond). Funding the new wallet isn't enough, and the allow-listing doesn't carry over on rotation, so without a reminder this silently breaks every Sophon deploy until someone rediscovers it. This adds a "Sophon deployer allow-list" callout to the deployer-rotation skill's Phase 1 (bootstrap), placed right next to the existing HyperEVM big-blocks callout, since both are the same per-address enablement that a rotation must re-do. Edited the source-of-truth file under .agents/commands/; the .claude/skills/ and .cursor/commands/ entries are symlinks and pick it up automatically. Requested by Daniel in #dev-sc-multisig-proposals.

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

@lifi-action-bot lifi-action-bot marked this pull request as draft July 16, 2026 11:12
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The deployer wallet rotation documentation adds a Phase 1 manual step to initiate Sophon allow-listing for the new deployer and clarifies that this restriction does not block subsequent rotation phases.

Changes

Deployer wallet rotation

Layer / File(s) Summary
Sophon allow-list bootstrap guidance
.agents/commands/rotate-deployer-wallet.md
Phase 1 instructs operators to start Sophon allow-listing during bootstrap because deployments reject unlisted deployers, while other rotation phases remain available.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the doc update and the Sophon allow-list reminder for the deployer rotation skill.
Description check ✅ Passed The description includes the Linear task, rationale, and the required review checklists with clear context.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/exsc-648-sophon-allowlist-reminder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gvladika gvladika marked this pull request as ready for review July 16, 2026 11:27
@gvladika gvladika enabled auto-merge (squash) July 16, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants