docs(skills): remind to allow-list new deployer on Sophon in rotate-deployer-wallet#2070
Open
gvladika wants to merge 1 commit into
Open
docs(skills): remind to allow-list new deployer on Sophon in rotate-deployer-wallet#2070gvladika wants to merge 1 commit into
gvladika wants to merge 1 commit into
Conversation
Contributor
WalkthroughThe deployer wallet rotation documentation adds a Phase 1 manual step to initiate Sophon allow-listing for the new deployer and clarifies that this restriction does not block subsequent rotation phases. ChangesDeployer wallet rotation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task belongs to this PR?
Fixes EXSC-648
Why did I implement it this way?
During the LayerSwapFacet zkSync-family rollout the Sophon deploy failed with
contract deployer address … is not in the allow list. Sophon gates contract deployment behind a per-EOA allow-list; the recently rotated deployer wasn't on it (the old deployer was — that's why Sophon already hosts our diamond). Funding the new wallet isn't enough, and the allow-listing doesn't carry over on rotation, so without a reminder this silently breaks every Sophon deploy until someone rediscovers it. This adds a "Sophon deployer allow-list" callout to the deployer-rotation skill's Phase 1 (bootstrap), placed right next to the existing HyperEVM big-blocks callout, since both are the same per-address enablement that a rotation must re-do. Edited the source-of-truth file under.agents/commands/; the.claude/skills/and.cursor/commands/entries are symlinks and pick it up automatically. Requested by Daniel in #dev-sc-multisig-proposals.Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)