feat(zksync): add LayerSwapFacet zkSync deploy + update scripts#2067
feat(zksync): add LayerSwapFacet zkSync deploy + update scripts#2067gvladika wants to merge 3 commits into
Conversation
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdds a zkSync deployment script for ChangesLayerSwapFacet deployment
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Which Linear task belongs to this PR?
Fixes EXSC-645
Why did I implement it this way?
Follow-up from the 38x LayerSwapFacet v1.0.0 rollout: abstract, sophon, and zksync (zkSync-family) were excluded from the main batch because the deployment must be compiled with zksolc, which requires zkSync-specific scripts. This adds both
script/deploy/zksync/DeployLayerSwapFacet.zksync.s.solandscript/deploy/zksync/UpdateLayerSwapFacet.zksync.s.sol, mirroring their counterparts underscript/deploy/facets/exactly — the only difference is that the./utils/…ScriptBase.solimports resolve to the zkSync-specific bases underscript/deploy/zksync/, which is the established convention (the same file pairs are byte-identical for e.g. GlacisFacet). Both scripts are required for a zkEVM rollout:deploySingleContract.shselectsDeploy*.zksync.s.solfor the CREATE3 deploy, anddiamondUpdateFacet.shhard-requiresscript/deploy/zksync/Update*.zksync.s.solto build thediamondCut(it aborts if the zkSync update script is missing rather than falling back to the non-zkSync one).config/layerswap.jsonalready contains abstract/sophon/zksynclayerSwapDepositoryentries, so no config change was needed. Verified both scripts compile under the pinned zksolc toolchain viaFOUNDRY_PROFILE=zksync forge build --zksync.Production deployment (LayerSwapFacet v1.0.0)
0xb59C89A4c9a8B8ff643f7b4e20c7df09CF25E0420xb59C89A4c9a8B8ff643f7b4e20c7df09CF25E042Each chain has one timelock-wrapped
diamondCutSafe proposal carrying the deployer's signature; the production<chain>.diamond.jsonregistries update only when the cuts execute. sophon is not included — its node rejects the deploy withcontract deployer address … is not in the allow list(Sophon gates contract deployment behind a deployer allow-list our deployer isn't on). That's an external, Sophon-side blocker tracked as follow-up; the scripts in this PR are ready to deploy it once the deployer is allowlisted.Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)