Skip to content

fix(ensureSCCoreDevApproval): re-evaluate core-dev-approval on PR lifecycle events (draft-skip bypass) #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xDEnYO wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −2
Open

fix(ensureSCCoreDevApproval): re-evaluate core-dev-approval on PR lifecycle events (draft-skip bypass) #2035

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97f3872
fix(ensureSCCoreDevApproval): re-run core-dev-approval on PR lifecycl…
0xDEnYO Jul 10, 2026
26d4eef
fix(ensureSCCoreDevApproval): run unconditionally on drafts so the ch…
0xDEnYO Jul 10, 2026
2955984
Merge branch 'main' into fix/core-dev-approval-draft-skip
gvladika Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/ensureSCCoreDevApproval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,31 @@
# - Smart Contract Core Dev Approval checker
# - makes sure that every pull_request is at least reviewed by one Smart Contract Core Developer
# (member of group https://github.com/orgs/lifinance/teams/smart-contract-core)
# - re-evaluates on review submission/dismissal AND on PR lifecycle events (opened, reopened,
# ready_for_review, synchronize) so the verdict on the head commit is always current
# - runs unconditionally (also on draft PRs): GitHub counts a "skipped" check run as passing
# a required status check, so this job must NEVER skip — a draft-time skip standing as the
# final verdict is exactly how an unapproved PR could reach main

name: SC Core Dev Approval Check

on:
pull_request_review:
types: [submitted]
types: [submitted, dismissed]
pull_request:
types: [opened, reopened, ready_for_review, synchronize]

permissions:
pull-requests: read # required to read PR reviews and metadata
contents: read # required to read local workspace contents (e.g. access tmp file)

concurrency:
group: core-dev-approval-${{ github.event.pull_request.number }}
cancel-in-progress: true

jobs:
core-dev-approval:
if: ${{ github.event.pull_request.draft == false }} # will only run once the PR is in "Ready for Review" state
# no draft condition on purpose — a skipped run counts as passing for branch protection
runs-on: ubuntu-latest
steps:
- name: Get smart-contract-core Team Members
Expand Down
Loading