fix(security): fix remaining template injection in protectAuditLabels workflow#1984
Open
mirooon wants to merge 1 commit into
Open
fix(security): fix remaining template injection in protectAuditLabels workflow#1984mirooon wants to merge 1 commit into
mirooon wants to merge 1 commit into
Conversation
… workflow
Move inline ${{ github.event.action }} and ${{ github.actor }} references
in the first two steps into env: blocks, matching the pattern already used
in the third step.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe workflow now passes ChangesAudit-label protection workflow
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0xDEnYO
approved these changes
Jul 16, 2026
8 tasks
melianessa
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why did I implement it this way?
Follow-up to Aikido's auto-fix PR #1728, which was closed because its specific changes were already applied to the repo. Two earlier steps in
protectAuditLabels.ymlstill contained direct${{ github.* }}references insiderun:scripts, leaving them vulnerable to template injection. This PR moves them intoenv:blocks, matching the pattern already used in the "Protect Audit Labels" step.Fixed references:
EVENT_ACTION="${{ github.event.action }}"(inline shell assignment, "Check if event requires audit label protection" step)"${{ github.actor }}"and${{ github.actor }}("Check for authorized actor" step)Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)