ci: turn the Android x86 job back on - #578
Open
WizzardSK wants to merge 1 commit into
Open
Conversation
It builds. mamearcade for android-x86 links a 249 MB ELF 32-bit i386 shared object with the current NDK, on the same platform= line the other three ABIs use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
android-x86is the one ABI commented out in.gitlab-ci.yml, and it builds today. Uncommenting it is the whole change.I ran it on a GitHub runner with the same
platform=android-x86line the other three ABIs use, NDK 29.0.14206865,TARGET=mame SUBTARGET=arcade:Nothing else needed touching — no source changes, no flags beyond what the
android-maketemplate already passes. 32-bit is not a problem for this tree in general either:linux-i686,windows-i686andandroid-armeabi-v7aare all active and green.I have not run it on the buildbot's own image, so if there is a reason this was switched off that is not "it did not build", I have not seen it — the commit that commented it out would know better than I do.