Dynamic side loading of cores#18788
Open
dragoonDorise wants to merge 1 commit intolibretro:masterfrom
Open
Conversation
Collaborator
|
Let me see if I can get some discussion going on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines
C89_BUILD=1Description
This PR allows RetroArch Android to sideload cores using the LIBRETRO argument, you can pass a path in that argument and the code will copy that core to /data/user/0 if it's not there already.
Launch command example:
That command will copy /storage/emulated/0/RetroArch/cores/gambatte_libretro_android.so to /data/data/com.retroarch/cores/mgba_libretro_android.so and use it to launch the provided {file.path}
This has been tested with launchers like ESDE that uses the current LIBRETO argument and has been proved to work too if the user has manually downloaded the core.
-e LIBRETRO /data/data/com.retroarch/cores/mgba_libretro_android.soIn a nutshell, you can use the data/data path or a custom path, the code takes care of it.
Related Issues
None
Related Pull Requests
None
Reviewers
[If possible @mention all the people that should review your pull request]