protos: force vlanId to be numeric#633
Merged
Merged
Conversation
G10h4ck
approved these changes
Oct 27, 2019
Contributor
|
As I understand this is fixing bugs as the vlanID is always a string the way it is passed now. I am +1 in the fix, only hoping that we can add tests. |
spiccinini
approved these changes
Nov 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between the arguments which can be provided to the routing protocols, the first one is usually the VLAN ID.
Force it to be numeric, for all the protocols except Batman-adv one which can be parametrized with %N1 (and except Babeld which is being treated in #631).