Repository navigation
Drop typing.Dict/List/Tuple in favor of builtin generics - #183
Merged
Merged
Conversation
Python 3.8 support has been retired and the project now requires Python 3.9+, which supports PEP 585 generic aliases on builtin collection types. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Same PEP 585 rationale as the typing.Dict cleanup: the project now requires Python 3.9+, so these can be builtin generics instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing.Dict,typing.List, andtyping.Tuplewith the builtindict/list/tuplegeneric aliases (PEP 585), now that Python 3.8 support has been retired and the project requires Python 3.9+.typingimports accordingly.Union/Optionalare left as-is since converting those toX | Ysyntax needs Python 3.10+, not just the 3.9 floor.Test plan
python -m py_compileon all touched files