Repository navigation
Reduce ordinary numerical test runtime and Windows LDC coverage memory - #305
Merged
Merged
Conversation
Retain representative precision and boundary checks in ordinary CI while moving the remaining binomial-log Fp!128 and Poisson-log Fp!128 and Fp!256 reference cases to the slow-numerics suite. Update the generators to reproduce the partition and preserve all 454 existing reference rows. Local validation confirms that the optimized slow suite executes the moved cases and ordinary Linux coverage retains the covered production lines. AI-Assisted-By: Codex (GPT-6 Astra Medium)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Run the Fp!256 and Fp!512 reference cases for 57 failures before 19 successes and 7 failures before 12 successes in the slow-numerics suite. Retain the same inputs at lower precisions and the remaining boundary cases at all four precisions in ordinary CI. Update the generator to preserve all 36 reference rows across the 32 ordinary and four slow cases. Validate both suites on 32-bit DMD, the optimized slow-numerics DUB job on LDC, and ordinary Linux coverage after the move. AI-Assisted-By: Codex (GPT-6 Astra Medium)
jmh530
marked this pull request as ready for review
November 17, 2026 22:46
Compile descriptive tests and the remaining tests in sequential package builds, matching the Linux coverage groups. Preserve relative report paths, dependency selections, and resource logging. Collect reports for the existing upload steps, reject missing, empty, or duplicate reports, propagate build failures, and clean up temporary build directories. The local experiment preserved all 111 reports and covered lines, while reducing peak compiler memory from 18.1 to 12.0 GiB. All 90 test modules passed before the known local coverage shutdown failure. Validate the complete workflow in CI. AI-Assisted-By: Codex (GPT-6 Astra Medium)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce ordinary CI work by moving broader extended-precision log-probability reference cases to the optimized slow-numerics suite, and reduce Windows LDC coverage build memory by compiling descriptive and remaining tests separately.
Numerical reference tests
Retain representative precision and boundary checks in ordinary CI while moving broader binomial-log Fp!128, Poisson-log Fp!128/Fp!256, and four costly negative-binomial Fp!256/Fp!512 reference cases to slow numerics. Update the generators to reproduce the partition without removing reference cases.
Windows LDC coverage
Match the existing Linux descriptive/remaining grouping with two sequential package builds. Preserve relative coverage paths, reuse dependency selections, and retain resource logging for each group. Propagate build failures, reject missing, empty, or duplicate reports, and clean up temporary build directories.
Validation
Related to #157.
AI-Assisted-By: Codex (GPT-6 Astra Medium)