Adopt the Whitaker Dylint suite in the lint gate and CI - #16
Conversation
Add the missing trailing newline to src/lib.rs so that `cargo fmt --check` passes, and collapse a double blank line in AGENTS.md that tripped markdownlint's MD012 rule. Both failures predate this branch and block the lint gates that the Whitaker adoption relies upon.
Extend the `lint` Makefile target to run the Whitaker Dylint suite after Clippy, denying warnings via the existing RUST_FLAGS convention, with a WHITAKER variable alongside the other tool variables for overriding. In CI, cache the whitaker-installer binary and the cargo-binstall download cache, install whitaker-installer 0.2.5 via cargo binstall (provided by the shared setup-rust action), and run the installer before the lint step so that `make lint` exercises the suite. The suite reported no findings for this crate.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The pinned shared `setup-rust` action in this repository predates binstall provisioning, so the Whitaker install step failed with "no such command: `binstall`". Try binstall first and build the installer from crates.io otherwise; the cached binary makes the fallback a one-off cost.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18991e44f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pass WHITAKER_INSTALLER_VERSION to the run block through the shell
environment rather than inline `${{ env }}` template expansion, which
zizmor flags as a template-injection risk; the job-level `env:` block
already exports the variable. Add `--locked` to the cargo binstall
invocation so that its compile-from-source fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This pull request adopts the Whitaker Dylint suite (v0.2.5) in the lint
gate and CI, as part of the estate-wide rollout following the reference
adoption in leynos/netsuke#410.
The
lintMakefile target now runs the suite after Clippy, denyingwarnings via the repository's existing
RUST_FLAGSconvention, with aWHITAKERvariable declared alongside the other tool variables so thebinary can be overridden. CI caches the
whitaker-installerbinary andthe cargo-binstall download cache, installs
whitaker-installer0.2.5via
cargo binstall(provided by the sharedsetup-rustaction), andruns the installer before the lint step.
The suite reported no findings for this crate, so no code changes or
dylint.tomlexclusions were required. Although this is a WASM plugincrate, the current stub has no wasm-only target configuration, so the
suite ran with the full
--all-targets --all-featuresset.Two pre-existing gate failures were fixed in a preparatory commit: a
missing trailing newline in
src/lib.rs(failingcargo fmt --check)and a double blank line in
AGENTS.md(failing markdownlint MD012).Review walkthrough
Makefile:adds
WHITAKER ?= whitakerand appends the suite to thelinttarget after Clippy.
.github/workflows/ci.yml:adds the
WHITAKER_INSTALLER_VERSIONjob environment variable, acache step for the installer and binstall cache, and an install step
before the lint step.
src/lib.rsand
AGENTS.md:pre-existing formatting and Markdown lint fixes.
Validation
whitaker --all -- --all-targets --all-features(withRUSTFLAGS="-D warnings"): no findings, exit 0.make check-fmt: passes.make lint(Clippy, cargo doc, and the Whitaker suite): passes.make test: passes (no tests yet in this stub crate).make markdownlint: passes.make nixie: all Mermaid diagrams validated successfully.