Adopt the Whitaker Dylint suite in the lint gate and CI - #44
Conversation
Wire the Whitaker Dylint suite into the Rust lint path as part of the estate-wide rollout (see leynos/netsuke#410 for the reference adoption). The repository previously had no Makefile target for Rust linting: the `lint` target runs the two-tier Python gate, and the developers' guide listed `cargo fmt`/`cargo check` as manual commands for Rust changes. Preserve that Python/Rust split by adding a dedicated `lint-rust` target that runs Clippy and then Whitaker over the `rust/` workspace with warnings denied, alongside new `CARGO` and `WHITAKER` tool variables. In CI, install the suite via `whitaker-installer` (pinned at 0.2.5, cached, with a cargo-binstall-or-build fallback for runners without binstall) and run `make lint-rust` after the Python lint step. The suite reported no findings against the existing crate, so no code changes were required. Document the new gate in the developers' guide.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 724f183ade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace inline `${{ env.WHITAKER_INSTALLER_VERSION }}` interpolation in the
run block with the plain shell variable `"${WHITAKER_INSTALLER_VERSION}"`;
the job-level `env:` already exports it, and zizmor flags run-block template
interpolation as a template-injection hazard. Add `--locked` to the
cargo-binstall invocation so that binstall's compile fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This pull request adopts the Whitaker Dylint suite in prosidy-darn's Rust lint path, as part of the estate-wide rollout (reference adoption: leynos/netsuke#410).
The repository previously had no Makefile target for Rust linting:
make lintruns the two-tier Python gate, and the developers' guide listedcargo fmtandcargo checkas manual commands for Rust extension changes. This change preserves that Python/Rust split by introducing a dedicatedlint-rusttarget that runs Clippy and then the Whitaker suite over therust/workspace with warnings denied. Continuous integration installs the suite viawhitaker-installer(pinned at 0.2.5, cached, with a cargo-binstall-or-build fallback for runners lackingcargo binstall) and runs the new target after the Python lint step.The suite reported no findings against the existing crate, so no code changes or
dylint.tomlexclusions were required.Review walkthrough
Makefile: adds theCARGOandWHITAKERtool variables and thelint-rusttarget, which runs Clippy followed by the Whitaker suite from therust/Cargo root..github/workflows/ci.yml: pinsWHITAKER_INSTALLER_VERSIONas job environment, caches the installer binary and the cargo-binstall cache, installs the suite, and runsmake lint-rust.docs/developers-guide.md: documents the new gate under the Rust extension quality gates, including how to install thewhitakerwrapper.Validation
mbake validate Makefile: valid syntax.make lint-rust: Clippy and the Whitaker suite (v0.2.5, toolchainnightly-2025-09-18) both finish with no findings.make check-fmt lint typecheck test markdownlint: all pass (20 tests passed; 33 Markdown files, 0 errors).make nixie: all Mermaid diagrams validate.git diff --check: clean.