Adopt the Whitaker Dylint suite in the lint gate and CI

.github/dependabot.yml

@@ -18,6 +18,7 @@ updates:
   - package-ecosystem: "cargo"
     directories:
       - "/"
+      - "/ambient_fs"
       - "/test_support"
     open-pull-requests-limit: 5
     labels:

.github/workflows/ci.yml

@@ -26,6 +26,7 @@ jobs:
       BUILD_PROFILE: debug
       # Override rust-toolchain.toml to actually use the matrix toolchain
       RUSTUP_TOOLCHAIN: ${{ matrix.rust }}
+      WHITAKER_INSTALLER_VERSION: '0.2.5'
     steps:
       - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633  # v4.1.2
       - name: Setup Rust
@@ -42,8 +43,34 @@ jobs:
         run: ninja --version
       - name: Format
         run: make check-fmt
+      - name: Cache Whitaker installer
+        if: matrix.rust == 'stable'
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830  # v4.3.0
+        with:
+          path: |
+            ~/.cargo/bin/whitaker-installer
+            ~/.cache/cargo-binstall
+          key: whitaker-installer-${{ runner.os }}-${{ runner.arch }}-${{ env.WHITAKER_INSTALLER_VERSION }}
+      - name: Install Whitaker
+        if: matrix.rust == 'stable'
+        run: |
+          if ! command -v whitaker-installer >/dev/null 2>&1; then
+            if cargo binstall --version >/dev/null 2>&1; then
+              cargo binstall --no-confirm --locked "whitaker-installer@${WHITAKER_INSTALLER_VERSION}"
+            else
+              echo "cargo-binstall unavailable; building whitaker-installer from crates.io"
+              cargo install --locked whitaker-installer --version "${WHITAKER_INSTALLER_VERSION}"
+            fi
+          fi
+          whitaker-installer
       - name: Lint
+        if: matrix.rust == 'stable'
         run: make lint
+      # Whitaker lints under its own pinned toolchain, so re-running it per
+      # matrix leg repeats identical work; non-stable legs run Clippy only.
+      - name: Lint (Clippy only)
+        if: matrix.rust != 'stable'
+        run: make lint-clippy
       - name: Setup uv
         uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39
         with:

AGENTS.md

@@ -146,11 +146,16 @@ project:
   - `make lint` executes:
 
     ```sh
-    cargo clippy --workspace --all-targets --all-features -- -D warnings
+    cargo doc --no-deps
+    cargo clippy --all-targets --all-features -- -D warnings
+    whitaker --all -- --all-targets --all-features
     ```
 
-    linting every target with all features enabled and denying all Clippy
-    warnings.
+    linting every target with all features enabled, denying all Clippy
+    warnings, and running the Whitaker Dylint suite (see
+    `docs/whitaker-users-guide.md`; install via `cargo install
+    whitaker-installer && whitaker-installer`). `make lint-clippy` runs the
+    Clippy-only subset when Whitaker is unavailable.
   - `make test` executes:
 
     ```sh

Cargo.toml

@@ -60,6 +60,7 @@ tracing-subscriber = { version = "0.3", features = ["fmt"] }
 serde_json = { version = "1", features = ["preserve_order"] }
 serde_json_canonicalizer = "0.3"
 tempfile = "3.8.0"
+ambient_fs = { path = "ambient_fs" }
 shell-quote = { version = "0.7.2", default-features = false, features = ["sh"] }
 shlex = "1.3.0"
 time = { version = "0.3.44", features = ["formatting", "macros", "parsing", "serde"] }
@@ -145,7 +146,7 @@ result_large_err                    = "deny"
 unknown_lints                       = "deny"
 renamed_and_removed_lints           = "deny"
 missing_docs                        = "deny"
-unexpected_cfgs                     = { level = "warn", check-cfg = ["cfg(kani)"] }
+unexpected_cfgs                     = { level = "warn", check-cfg = ["cfg(kani)", "cfg(dylint_lib, values(any()))"] }
 
 [lints.rustdoc]
 missing_crate_level_docs            = "deny"
@@ -179,3 +180,19 @@ trybuild = "1.0.116"
 [target.'cfg(unix)'.dev-dependencies]
 # Used only to construct FIFOs and device nodes in tests.
 rustix = { version = "1.0.8", features = ["fs"] }
+
+[workspace]
+# `ambient_fs` is the sanctioned ambient-filesystem escape hatch, so it must be a
+# workspace member for the root-level `cargo fmt`, `cargo doc`, `cargo clippy`, and
+# `cargo test` gates to format, document, lint, and run its doctests and unit tests.
+members = ["ambient_fs"]
+# Operate on both packages by default so the bare-cargo gates (`cargo test`,
+# `cargo check`, `cargo clippy`, `cargo doc`) cover `ambient_fs` without needing
+# `--workspace`; the root package (netsuke, ".") is listed explicitly because a
+# default set that omitted it would stop gating netsuke itself.
+default-members = [".", "ambient_fs"]
+# `test_support` is a path dependency that Cargo would otherwise auto-include as a
+# member. It is excluded here to keep its gate coverage unchanged in this focused
+# change; folding it into the workspace is tracked separately as it requires
+# clearing its own lint backlog.
+exclude = ["test_support"]

Makefile

@@ -1,4 +1,4 @@
-.PHONY: help all clean test test-workflow-contracts test-typos-config build release lint fmt check-fmt typecheck markdownlint nixie install-kani kani-check kani-full kani-ir install-verus verus formal-pr
+.PHONY: help all clean test test-workflow-contracts test-typos-config build release lint lint-clippy lint-whitaker fmt check-fmt typecheck markdownlint nixie install-kani kani-check kani-full kani-ir install-verus verus formal-pr
 
 APP ?= netsuke
 CARGO ?= $(shell command -v cargo 2>/dev/null || printf '%s' "$$HOME/.cargo/bin/cargo")
@@ -26,8 +26,9 @@ PROVER_TOOLS ?= uv tool run --from $(PROVER_TOOLS_SOURCE) prover-tools
 RUSTDOC_FLAGS ?= --cfg docsrs -D warnings
 VERUS_FLAGS ?=
 VERUS_INSTALL_FLAGS ?=
+WHITAKER ?= whitaker
 
-export PATH := $(HOME)/.cargo/bin:$(HOME)/.bun/bin:$(PATH)
+export PATH := $(HOME)/.cargo/bin:$(HOME)/.local/bin:$(HOME)/.bun/bin:$(PATH)
 
 build: target/debug/$(APP) ## Build debug binary
 release: target/release/$(APP) ## Build release binary
@@ -49,10 +50,15 @@ test-typos-config: ## Verify typos.toml matches its generator
 target/%/$(APP): ## Build binary in debug or release mode
 	$(CARGO) build $(BUILD_JOBS) $(if $(findstring release,$(@)),--release) --bin $(APP)
 
-lint: ## Run Clippy with warnings denied
+lint: lint-clippy lint-whitaker ## Run Clippy and the Whitaker Dylint suite with warnings denied
+
+lint-clippy: ## Run rustdoc and Clippy with warnings denied
 	RUSTDOCFLAGS="$(RUSTDOC_FLAGS)" $(CARGO) doc --no-deps
 	$(CARGO) clippy $(CLIPPY_FLAGS)
 
+lint-whitaker: ## Run the Whitaker Dylint suite with warnings denied
+	RUSTFLAGS="-D warnings" $(WHITAKER) --all -- --all-targets --all-features
+
 fmt: ## Format Rust and Markdown sources
 	$(CARGO) fmt --all
 	mdformat-all

ambient_fs/Cargo.toml

@@ -0,0 +1,54 @@
+[package]
+name = "ambient_fs"
+version = "0.1.0"
+edition = "2024"
+rust-version = "1.89.0"
+publish = false
+
+[dependencies]
+camino = "1.2.0"
+walkdir = "2.5"
+
+[dev-dependencies]
+rstest = "0.26.1"
+tempfile = "3.8.0"
+
+[lints.clippy]
+pedantic = { level = "warn", priority = -1 }
+
+# 1. hygiene
+# Unfortunately, due to an 'unused-braces' false positive with
+# single line rstest fixtures, and the fact that fixtures do
+# not permit 'expect' attributes, we must disable this deny.
+# allow_attributes                    = "deny"
+allow_attributes_without_reason     = "deny"
+blanket_clippy_restriction_lints    = "deny"
+
+# 2. debugging leftovers
+# Disabled pending further investigation into applicability.
+# dbg_macro       = "deny"
+# print_stdout    = "deny"
+# print_stderr    = "deny"
+
+# 3. panic-prone operations
+unwrap_used                     = "deny"
+# Expect used in tests. Discouraged in implementation code.
+# expect_used                     = "deny"
+indexing_slicing                = "deny"
+string_slice                    = "deny"
+integer_division                = "deny"
+integer_division_remainder_used = "deny"
+
+# 4. portability
+host_endian_bytes   = "deny"
+little_endian_bytes = "deny"
+big_endian_bytes    = "deny"
+
+# 5. nursery idiom polish
+or_fun_call            = "deny"
+option_if_let_else     = "deny"
+use_self               = "deny"
+string_lit_as_bytes    = "deny"
+
+# 6. numerical foot-guns
+float_arithmetic = "deny"