Adopt the Whitaker Dylint suite in the lint gate and CI - #18
Conversation
The repository already ran the Whitaker Dylint suite in `make lint` and CI, but pinned the installer to a git revision and cached the built suite wholesale. Align the workflow with the estate-wide adoption pattern (leynos/netsuke#410): - Pin `WHITAKER_INSTALLER_VERSION` to the 0.2.5 crates.io release in place of the raw git revision. - Cache only the installer binary and the cargo-binstall cache, keyed on OS, architecture, and installer version. - Install via `cargo binstall`, falling back to `cargo install` when binstall is unavailable, then run `whitaker-installer` on every job so the suite matches the pinned release. - Mention Whitaker in the `lint` target's help text. The suite reports no findings against the current code, and the Dependabot-actor audit skip is untouched.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 6 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This project builds with the Cranelift debug backend, so the Dylint driver's pinned nightly needs `rustc-codegen-cranelift` installed. Restore the installer's `--cranelift` flag, which the standardized install step had dropped.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cff3b95ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pass WHITAKER_INSTALLER_VERSION to the run block through the shell
environment rather than inline `${{ env }}` template expansion, which
zizmor flags as a template-injection risk; the job-level `env:` block
already exports the variable. Add `--locked` to the cargo binstall
invocation so that its compile-from-source fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This change aligns monotony with the estate-wide Whitaker Dylint suite
rollout (see leynos/netsuke#410 for the reference adoption). The
repository already ran the suite in
make lintand CI, but pinned theinstaller to a raw git revision and cached the entire built suite. The
workflow now pins
WHITAKER_INSTALLER_VERSIONto the 0.2.5 crates.iorelease, caches only the installer binary and the cargo-binstall cache,
and installs via
cargo binstallwith acargo installfallback forrunners without binstall. Running
whitaker-installeron every jobensures the suite always matches the pinned release. The
linttarget's help text now mentions Whitaker. The suite reports no findings
against the current code, and the Dependabot-actor audit skip in CI is
untouched.
Review walkthrough
.github/workflows/ci.yml:replaces the git-revision pin with
WHITAKER_INSTALLER_VERSION: '0.2.5', narrows the cache to the installer binary and binstallcache, and adopts the binstall-or-build install step.
Makefile:updates the
linttarget's help text to mention the Whitaker suite,which the target already runs after Clippy.
Validation
whitaker --all -- --all-targets --all-featureswithRUSTFLAGS="-D warnings": exit 0, no findings.mbake validate Makefile: valid syntax.make check-fmt,make lint,make typecheck,make test,make markdownlint, andmake nixie: all pass.