Skip to content

Align Dependabot coverage and add the dev-fast build fragment - #20

Draft
leynos wants to merge 4 commits into
mainfrom
parabellum-wave-1
Draft

Align Dependabot coverage and add the dev-fast build fragment#20
leynos wants to merge 4 commits into
mainfrom
parabellum-wave-1

Conversation

@leynos

@leynos leynos commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

This branch applies Wave 1 of the Rust estate baseline remediation
(Operation Parabellum, phase 2). It aligns
.github/dependabot.yml
with the canonical Dependabot reference: one update stanza per package
ecosystem the repository uses (cargo, rust-toolchain, github-actions), each stanza labelled
dependencies plus its channel label, and GitHub Actions updates batched
into a single pull request via a wildcard group. It also adds the opt-in dev-fast build
fragment with dev-build and dev-test Make targets, signposted in
AGENTS.md.

Review walkthrough

Validation

  • Audited the amended tree with the Concordat rule packages
    dependabot-baseline and rust-dev-fast-baseline: dependabot-baseline compliant, rust-dev-fast-baseline compliant.

Notes

  • The canonical labels (including the Dependabot channel labels this
    configuration references) were created on the repository ahead of this
    pull request, so no stanza names a missing label.
  • The dev-fast fragment is strictly opt-in local tooling: it is only
    applied when passed explicitly with --config, so continuous
    integration, release, coverage, and verification builds are untouched.
    The targets need a nightly toolchain and, on Linux, a mold binary on
    the PATH; repositories still pinned to stable gain the wiring now and
    the capability when Wave 2 moves the pin to nightly.

Summary by Sourcery

Align Dependabot configuration with Rust tooling coverage and add an opt-in fast development build path.

Enhancements:

  • Introduce opt-in accelerated debug build and test targets wired through a dedicated Cargo config fragment for Cranelift and mold.

Build:

  • Add nightly-only dev-build and dev-test Make targets that use a separate Cargo config fragment for fast local debug builds.
  • Extend Dependabot configuration to include weekly updates for the rust-toolchain ecosystem with appropriate dependency labels.

Documentation:

  • Document the fast development build workflow, prerequisites, and isolation from release and verification builds in AGENTS.md.

Bring `.github/dependabot.yml` to the estate baseline: one update
stanza per package ecosystem the repository uses, each labelled
`dependencies` plus its channel label, with GitHub Actions updates
batched into a single pull request via a wildcard group.

Add the opt-in dev-fast build fragment at
`tools/dev-fast/config.toml` (Cranelift codegen for the dev profile
and the mold linker on Linux) with `dev-build` and `dev-test` Make
targets that pass it explicitly via `--config`, and signpost the
workflow in `AGENTS.md`. Release, coverage, and verification builds
are unaffected: the fragment is never auto-discovered.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2d60c5ae-8dfe-4a5a-996e-75fd7af723be

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Reviewer's Guide

Aligns Dependabot configuration with the canonical Rust estate baseline and introduces an opt-in dev-fast build fragment with corresponding Make targets and documentation.

Sequence diagram for opt-in dev-fast build and test targets

sequenceDiagram
  actor Developer
  participant Makefile
  participant Cargo
  participant Cranelift_backend as Cranelift
  participant mold_linker as mold

  Developer->>Makefile: make dev-build
  Makefile->>Cargo: cargo --config tools/dev-fast/config.toml build
  Cargo->>Cranelift: use profile.dev codegen-backend="cranelift"
  alt [target_os = "linux"]
    Cargo->>mold: rustflags -Clink-arg=-fuse-ld=mold
  else [non-linux]
    Cargo->>Cargo: use platform_default_linker
  end

  Developer->>Makefile: make dev-test
  Makefile->>Cargo: cargo --config tools/dev-fast/config.toml test
  Cargo->>Cranelift: use profile.dev codegen-backend="cranelift"
  alt [target_os = "linux"]
    Cargo->>mold: rustflags -Clink-arg=-fuse-ld=mold
  else [non-linux]
    Cargo->>Cargo: use platform_default_linker
  end
Loading

File-Level Changes

Change Details Files
Introduce opt-in accelerated debug build targets wired to a shared Cargo config fragment.
  • Define DEV_FAST_CONFIG variable defaulting to tools/dev-fast/config.toml.
  • Add dev-build and dev-test phony targets using cargo --config to build and test with the dev-fast configuration.
  • Annotate the new targets as debug-only, nightly-dependent Cranelift+mold builds and keep them isolated from other build flows.
Makefile
Document usage and constraints of the dev-fast build fragment for contributors.
  • Add a 'Fast development builds' section explaining make dev-build and make dev-test.
  • Clarify nightly toolchain and mold-on-Linux requirements and that the fragment is passed explicitly via --config.
  • Warn against copying the fragment into .cargo/config.toml to avoid affecting release, coverage, and verification builds.
AGENTS.md
Align Dependabot configuration with canonical Rust baseline, including rust-toolchain coverage.
  • Add a rust-toolchain package-ecosystem stanza scoped to the repository root.
  • Apply canonical dependency labels, including dependencies and rust-toolchain, to the new stanza.
  • Ensure scheduling is set to weekly to match baseline remediation guidance.
.github/dependabot.yml
Add canonical dev-fast Cargo configuration fragment for accelerated local debug builds.
  • Introduce an opt-in Cargo config TOML that enables the unstable codegen-backend feature.
  • Configure the dev profile to use the Cranelift backend for faster compilation.
  • Gate mold linker usage behind a Linux-only target cfg via rustflags to keep other platforms on their default linker.
  • Document interaction with existing rustflags in .cargo/config.toml and why this fragment remains external and explicit.
tools/dev-fast/config.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

The dev-fast rollout writes "mold" (the linker) into AGENTS.md and
the Makefile, and the en-GB-oxendict spelling gate reads it as a
misspelling of "mould", failing CI. Accept the word via the estate's
correction-to-itself pattern in `typos.local.toml`, and mirror it in
the generated dictionary so local runs agree with the regenerated
configuration.
@leynos

leynos commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

The spelling gate failed on this branch because the appended dev-fast text names the mold linker, which the en-GB-oxendict dictionary read as a misspelling of “mould”. The follow-up commit accepts the word via the estate's correction-to-itself pattern in typos.local.toml (mirrored in the generated dictionary); the AGENTS.md and Makefile hunks are untouched, so the companion parabellum-wave-2-3 branches still merge cleanly where they exist.

leynos added 2 commits August 13, 2026 23:34
A blanket `mold = "mold"` correction disables detection of genuine
"mould" misspellings everywhere in the repository. Replace it with
pattern-scoped exemptions covering only the linker contexts the
dev-fast rollout introduced (`-fuse-ld=mold`, "mold linker",
"Cranelift + mold", "Cranelift and mold", and backticked `mold`),
and mirror them in the generated dictionary. Text such as "the bread
had mold growing on it" is flagged again.
Estate review flagged two defects in the fragment's deployed
comments: a stale "copy this fragment" instruction that reads as
nonsense once the file is in place, and a mis-statement of Cargo's
rustflags semantics (Cargo joins the entries of every matching
`[target.*]` table; only the joined result takes precedence over
`[build].rustflags` rather than merging). Both are corrected in the
canonical source; take its bytes verbatim. No configuration key
changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant