Skip to content

Adopt the Whitaker Dylint suite in the lint gate and CI #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leynos merged 3 commits into from
Jul 9, 2026
Merged

Adopt the Whitaker Dylint suite in the lint gate and CI #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91ee17c
Adopt the Whitaker Dylint suite in the lint gate and CI
Jul 8, 2026
67220bf
Fall back to cargo install when cargo-binstall is unavailable
Jul 8, 2026
4848e41
Harden the Whitaker install step
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
env:
CARGO_TERM_COLOR: always
BUILD_PROFILE: debug
WHITAKER_INSTALLER_VERSION: '0.2.5'
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
- name: Setup Rust
Expand All @@ -26,6 +27,24 @@ jobs:
**/*.md
!**/target/**
!**/dist/**
- name: Cache Whitaker installer
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: |
~/.cargo/bin/whitaker-installer
~/.cache/cargo-binstall
key: whitaker-installer-${{ runner.os }}-${{ runner.arch }}-${{ env.WHITAKER_INSTALLER_VERSION }}
- name: Install Whitaker
run: |
if ! command -v whitaker-installer >/dev/null 2>&1; then
if cargo binstall --version >/dev/null 2>&1; then
cargo binstall --no-confirm --locked "whitaker-installer@${WHITAKER_INSTALLER_VERSION}"
else
echo "cargo-binstall unavailable; building whitaker-installer from crates.io"
cargo install --locked whitaker-installer --version "${WHITAKER_INSTALLER_VERSION}"
fi
fi
whitaker-installer
Comment thread
coderabbitai[bot] marked this conversation as resolved.
- name: Lint
run: make lint
- name: Test and Measure Coverage
Expand Down
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CLIPPY_FLAGS ?= --all-targets --all-features -- $(RUST_FLAGS)
TEST_FLAGS ?= --all-targets --all-features
MDLINT ?= markdownlint-cli2
NIXIE ?= nixie
WHITAKER ?= whitaker

build: target/debug/$(APP) ## Build debug binary
release: target/release/$(APP) ## Build release binary
Expand All @@ -26,8 +27,9 @@ test: ## Run tests with warnings treated as errors
target/%/$(APP): ## Build binary in debug or release mode
$(CARGO) build $(BUILD_JOBS) $(if $(findstring release,$(@)),--release) --bin $(APP)

lint: ## Run Clippy with warnings denied
lint: ## Run Clippy and the Whitaker Dylint suite with warnings denied
$(CARGO) clippy $(CLIPPY_FLAGS)
RUSTFLAGS="$(RUST_FLAGS)" $(WHITAKER) --all -- --all-targets --all-features

fmt: ## Format Rust and Markdown sources
$(CARGO) fmt --all
Expand Down
Loading