Move cmd-mox behind a CommandRunner port (#62) - #76
Merged
leynos merged 4 commits intoJun 8, 2026
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch moves the cmd-mox IPC integration for issue #62 out of production modules and behind a
CommandRunnerport selected at the CLI boundary.Closes #62.
Production code now depends on the runtime command-runner protocol and default subprocess adapter, while the cmd-mox adapter lives under
lading.testingand is loaded only whenLADING_USE_CMD_MOX_STUBis enabled.Review walkthrough
Validation
make check-fmt: passed.make lint: passed with Ruff clean and Pylint at 10.00/10.make typecheck: passed withty checkclean.make test: passed, 465 tests and 14 snapshots.grep -R "cmd_mox" -n lading: passed with hits only under lading/testing/cmd_mox_runner.py.coderabbit review --agent: passed with zero findings after follow-up fixes.