Adopt the Whitaker Dylint suite in the lint gate and CI - #16
Conversation
`cargo fmt --check` failed on `src/lib.rs` because the file lacked a trailing newline, and `markdownlint` flagged two consecutive blank lines after the "Testing" heading in `AGENTS.md`. Both failures predate this branch and blocked the commit gates, so fix them here ahead of the Whitaker adoption change.
Extend `make lint` to run the Whitaker Dylint suite after Clippy, denying warnings via the existing `RUST_FLAGS` convention and reusing `CARGO_FLAGS` for the target selection. A `WHITAKER ?= whitaker` variable sits alongside the other tool variables so the binary can be overridden. In CI, install the suite before the lint step: pin `WHITAKER_INSTALLER_VERSION` to 0.2.5 at the job level, cache the `whitaker-installer` binary and the cargo-binstall download cache, and install via `cargo binstall` (provided by the shared `setup-rust` action) when the cache misses. The suite reported no findings for this crate; no code changes or `dylint.toml` exclusions were required. This is part of the estate-wide Whitaker rollout (see leynos/netsuke#410).
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: effe585e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The pinned shared `setup-rust` action in this repository predates binstall provisioning, so the Whitaker install step failed with "no such command: `binstall`". Try binstall first and build the installer from crates.io otherwise; the cached binary makes the fallback a one-off cost.
Pass WHITAKER_INSTALLER_VERSION to the run block through the shell
environment rather than inline `${{ env }}` template expansion, which
zizmor flags as a template-injection risk; the job-level `env:` block
already exports the variable. Add `--locked` to the cargo binstall
invocation so that its compile-from-source fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This change adopts the Whitaker Dylint suite (v0.2.5) as part of the
estate-wide rollout (reference adoption: leynos/netsuke#410). The
make linttarget now runs the suite after Clippy, denying warnings via the repository's
existing
RUST_FLAGSconvention and reusingCARGO_FLAGS(--all-targets --all-features), with aWHITAKER ?= whitakervariable alongside the othertool variables. The CI lint job pins
WHITAKER_INSTALLER_VERSIONto0.2.5,caches the installer binary and the cargo-binstall download cache, and installs
the suite via
cargo binstall(provided by the sharedsetup-rustaction)before the lint step.
The suite reported no findings for this crate, so no code fixes or
dylint.tomlexclusions were required. Although this is a WASM-targeted crate,--all-targetslinted cleanly under the Dylint toolchain, so the default flagset is retained. Two pre-existing gate failures were fixed in a preparatory
commit:
src/lib.rslacked a trailing newline (failingmake check-fmt) andAGENTS.mdcontained consecutive blank lines (failingmake markdownlint).Review walkthrough
Makefile:adds the
WHITAKERtool variable and appends the suite invocation to thelintrecipe, updating the target's help text..github/workflows/ci.yml:adds the
WHITAKER_INSTALLER_VERSIONjob environment variable, anactions/cachestep for the installer, and an install step ahead of thelint step.
src/lib.rsand
AGENTS.md:pre-existing formatting and Markdown lint fixes.
Validation
make check-fmt— passed.make lint(Clippy plus Whitaker suite, warnings denied) — passed with zerofindings.
make test— passed (no tests defined yet; the crate is a stub).make markdownlint— passed after theAGENTS.mdfix.make nixie— all Mermaid diagrams validated.