-
Notifications
You must be signed in to change notification settings - Fork 0
Adopt the phase 2 Rust baseline (toolchain, rustfmt, lints) #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ea77486
Align repo config with the phase 2 Rust baseline
leynos d384671
Fix disallowed_methods violation in the stub test
leynos d629fef
Restore pre-existing toolchain components
leynos 350a806
Add the opt-in dev-fast build so this branch stands alone
leynos 1fdba14
Document the Cargo.toml lint baseline in the developer guide
leynos 466cdae
Clarify that Cranelift stays pinned, only auto-use is gone
leynos a8eaa3f
Remove Cranelift and mold from the users' guide entirely
leynos ff59b5e
Fix .rustfmt.toml's stale copy-instruction comment
leynos b565177
Wire dev-fast into the standard build/test/lint/typecheck path
leynos 6d67f19
Add a contract test guarding the dev-fast Makefile wiring
leynos 9fe6178
Exempt inline code spans from the spelling gate
leynos 360cabe
Correct the Whitaker Cranelift comment in ci.yml
leynos cf11c72
Refresh tools/dev-fast/config.toml from canon
leynos 6f2a6f0
Scope the mold spelling exemption to specific phrasings
leynos 9ec187e
Correct the release.yml Cranelift comments
leynos d417550
Use $(CARGO) in the dev-fast Makefile block
leynos 6a47b4e
Harden the Makefile contract test to per-line assertions
leynos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,3 @@ | ||
| [unstable] | ||
| codegen-backend = true | ||
|
|
||
| [profile.dev] | ||
| codegen-backend = "cranelift" | ||
|
|
||
| [target.x86_64-unknown-linux-gnu] | ||
| linker = "clang" | ||
| rustflags = ["-C", "link-arg=-fuse-ld=mold"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,24 @@ | ||
| # Align with CodeScene’s ceiling | ||
| # Canonical clippy configuration for the estate. | ||
| # | ||
| # The thresholds align with CodeScene's code-health ceilings. | ||
| cognitive-complexity-threshold = 9 # default is 25 | ||
| too-many-arguments-threshold = 4 # default is 7 | ||
| too-many-lines-threshold = 70 # default is 100 | ||
| excessive-nesting-threshold = 4 # default is off | ||
|
|
||
| allow-expect-in-tests = true | ||
|
|
||
| # Enforce the environment-injection mandate. The reason strings surface in | ||
| # the diagnostic, so a contributor who trips one is told what to do instead. | ||
| # | ||
| # Sanctioned sites carry `#[expect(clippy::disallowed_methods, reason = "..")]` | ||
| # rather than `allow`, so the expectation goes unfulfilled — and warns — once | ||
| # the site is migrated. The backlog removes itself instead of rotting. | ||
| disallowed-methods = [ | ||
| { path = "std::env::var", reason = "inject an environment reader" }, | ||
| { path = "std::env::var_os", reason = "inject an environment reader" }, | ||
| { path = "std::env::vars", reason = "inject an environment reader" }, | ||
| { path = "std::env::vars_os", reason = "inject an environment reader" }, | ||
| { path = "std::env::set_var", reason = "use a stub environment in tests" }, | ||
| { path = "std::env::remove_var", reason = "use a stub environment in tests" }, | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.