Adopt the Whitaker Dylint suite in the lint gate and CI - #17
Conversation
Repair three failures that predate the Whitaker adoption so the full gate suite can pass: - Add the trailing newline `cargo fmt --check` demanded in `src/main.rs`. - Replace the `#[allow(clippy::print_stdout, ...)]` attribute on `main` with `#[expect(...)]`, as required by the crate-level `clippy::allow_attributes = "deny"` policy. - Remove a double blank line in `AGENTS.md` flagged by markdownlint (MD012).
Wire the Whitaker Dylint suite (v0.2.5) into the repository's lint gate as part of the estate-wide rollout (see leynos/netsuke#410): - Makefile: add a `WHITAKER ?= whitaker` tool variable and run the suite after Clippy in the `lint` target, denying warnings via the existing `RUST_FLAGS` convention. - CI: pin `WHITAKER_INSTALLER_VERSION` as job env, cache the installer binary and the cargo-binstall cache keyed on OS, architecture, and version, and install the suite via `cargo binstall` (provided by the shared setup-rust action) before the lint step. The suite reports no findings on this crate, so no code changes were required beyond the pre-existing gate fixes in the previous commit.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The pinned shared `setup-rust` action in this repository predates binstall provisioning, so the Whitaker install step failed with "no such command: `binstall`". Try binstall first and build the installer from crates.io otherwise; the cached binary makes the fallback a one-off cost.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4eaf5154e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pass WHITAKER_INSTALLER_VERSION to the run block through the shell
environment rather than inline `${{ env }}` template expansion, which
zizmor flags as a template-injection risk; the job-level `env:` block
already exports the variable. Add `--locked` to the cargo binstall
invocation so that its compile-from-source fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
The Clippy and test targets already honour a CARGO_FLAGS override via CLIPPY_FLAGS and TEST_FLAGS, but the Whitaker invocation hardcoded --all-targets --all-features. Pass $(CARGO_FLAGS) after the Dylint separator instead so callers overriding CARGO_FLAGS get consistent behaviour across all lint paths.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This pull request adopts the Whitaker Dylint suite (v0.2.5) in the
lint gate and CI, as part of the estate-wide rollout following
leynos/netsuke#410. The Makefile gains a
WHITAKER ?= whitakertoolvariable and the
linttarget now runs the suite after Clippy withwarnings denied via the repository's existing
RUST_FLAGSconvention.The CI workflow pins the installer version, caches the installer
binary and the cargo-binstall cache, and installs the suite before the
lint step using
cargo binstall(provided by the sharedsetup-rustaction).
The suite reported no findings on this crate. A preparatory commit
repairs three pre-existing gate failures: a missing trailing newline
in
src/main.rs, an#[allow]attribute forbidden by the crate'sclippy::allow_attributesdeny policy (now#[expect]), and adouble blank line in
AGENTS.mdflagged by markdownlint.Review walkthrough
Makefile:new
WHITAKERvariable and the Whitaker invocation appended to thelinttarget..github/workflows/ci.yml:WHITAKER_INSTALLER_VERSIONjob env, installer cache step, and theinstall step ahead of
make lint.src/main.rs:#[allow]replaced with#[expect]; trailing newline restored.AGENTS.md:duplicate blank line removed.
Validation
whitaker --all -- --all-targets --all-features(withRUSTFLAGS="-D warnings"): no findings, exit 0.make check-fmt lint test markdownlint: all pass.make nixie: all Mermaid diagrams validated.mbake validate Makefile: valid syntax.