Align Whitaker lint wiring with the estate rollout conventions - #197
Conversation
Cuprum already runs the Whitaker Dylint suite in `make lint` and in the CI lint-test job. This change brings the wiring in line with the conventions used across the estate rollout (see leynos/netsuke#410): - Introduce a `WHITAKER ?= whitaker` tool variable in the Makefile and use it in the lint recipe, so the binary can be overridden like the other tools. - Run Whitaker with `RUSTFLAGS="$(RUST_FLAGS)"` so warnings are denied during the lint build, matching the Clippy and test invocations, and mention Whitaker in the lint target's help text. - Add a binstall-or-build fallback to the CI install step: runners whose Rust setup does not provide `cargo binstall` now fall back to `cargo install --locked whitaker-installer` instead of failing. - Document a rationale for the existing `no_std_fs_operations` exclusion in rust/dylint.toml: the extension crate only wraps raw file descriptors and handles received from Python in std::fs::File and never opens filesystem paths itself. - Sync the `make lint` command listing in AGENTS.md with the new Whitaker invocation.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 36 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
…216) R503 previously said every function should end with an explicit return. That conflicted with the narrower intent of R502 and led to requests for bare `return` in procedures whose only possible result is `None`. Scope the terminal-return requirement to functions that may return a value elsewhere, and add a `GOOD` example showing all-`None` procedures do not need a final `return`. Co-authored-by: leynos <leynos@rohga>
1 participant
Summary
This change aligns cuprum's existing Whitaker Dylint wiring with the
conventions adopted across the estate rollout (see leynos/netsuke#410).
Cuprum already ran the suite in
make lintand installed it in the CIlint-test job; this pull request closes the remaining gaps rather than
introducing the suite from scratch:
WHITAKER ?= whitakertool variable, used by thelint recipe, so the binary can be overridden like the other tools; the
lint target's help text now mentions Whitaker.
RUSTFLAGS="$(RUST_FLAGS)"(
-D warnings), matching the Clippy and test invocations.the rollout: runners whose Rust setup does not provide
cargo binstallfall back to
cargo install --locked whitaker-installerinstead offailing. The Cranelift-backed
whitaker-installer --craneliftcall isunchanged.
no_std_fs_operationsexclusion inrust/dylint.tomlnow carries a rationale: the extension crate never opens filesystem
paths itself; it wraps raw file descriptors and handles received from
the Python caller in
std::fs::File.make lintcommand listing inAGENTS.mdis synchronized withthe new invocation.
The suite itself reports no findings; no code fixes were required.
Review walkthrough
Makefile:new
WHITAKERvariable and the updated lint recipe..github/workflows/ci.yml:binstall-or-build fallback in the Install Whitaker step.
rust/dylint.toml:rationale comment for the existing exclusion.
AGENTS.md:documentation kept in step with the Makefile.
Validation
RUSTFLAGS="-D warnings" whitaker --all -- --all-targets --all-featuresfrom
rust/: exit 0, no findings.make check-fmt lint typecheck test markdownlint nixie: all gatespass (Ruff, interrogate, pylint, cargo doc, Clippy, Whitaker, ty,
pytest, cargo nextest, markdownlint-cli2, nixie).
mbake validate Makefile: valid syntax.