Fix Whitaker test-helper assertions - #331
Conversation
Use Whitaker installer 0.2.7 so CI recognises helpers inside test-only modules and reports genuine lint violations rather than false positives.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Whitaker CI linter installer version to use the corrected test-context detection, ensuring test-only helpers are no longer linted as production code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Your free Security trial is over. An organization admin can activate billing to continue. |
|
Warning Your free Security trial is over. An organization admin can activate billing to continue. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Replace helper-level `expect` calls with the shared `ExpectValid` assertion boundary so Whitaker can distinguish intentional test failures from production error handling.
Pull Request
Summary
ExpectValidassertion boundary for test-only helpers.Change Type
Linked Issue
None; this is a targeted CI lint-regression repair.
Validation
make allmake typecheckmake markdownlintmake nixiegit diff --checkSecurity Impact
None. This changes test assertion boundaries and CI lint tooling only.
Database Impact
None. No schema, migration, query, or data changes.
Blast Radius
Limited to test helpers compiled by the Whitaker CI lint job.
Rollback Plan
Revert the shared assertion boundary and installer update if they prove incompatible.
Review track: C (CI)
References
Summary by Sourcery
Make test-helper assertions compatible with current Whitaker linting while preserving their failure diagnostics.
Bug Fixes:
Enhancements:
ExpectValidassertion boundary and apply it across test helpers and fixtures without changing test behavior.CI: