Add the canonical build Make target - #274
Draft
leynos wants to merge 1 commit into
Draft
Conversation
Concordat's estate baseline (rule `rust-makefile-baseline`, FP-003) requires a root `build` target alongside `test` and `lint`. Add one that compiles the workspace with all targets and the test-helpers feature set, mirroring the flags the lint and test targets already use, and register it in `.PHONY`.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size: XS
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds the canonical
buildMake target required byConcordat's estate baseline (rule
rust-makefile-baseline, checkFP-003: the root
Makefilemust definebuild,test, andlintunconditionally). The recipe compiles the workspace with
$(CARGO) build --all-targets $(TEST_FEATURES), matching the flagconventions of the existing lint and test targets.
Validation
make -n build: expands correctlymakeutil parse Makefile: statuscompleteconcordat artefact rule run rust-makefile-baseline: verdictcompliant(wasnoncompliantfor the missingbuildtarget)🤖 Generated with Claude Code