Adopt the Whitaker Dylint suite in the lint gate and CI - #26
Conversation
Harden the lint target so the Whitaker Dylint suite is a mandatory part of `make lint` rather than a soft, skip-if-absent extra. The recipe now uses a `WHITAKER ?= whitaker` tool variable alongside the other tool variables and reuses the existing `RUST_FLAGS` and `CARGO_FLAGS` conventions, so warnings are denied across all targets and features. Wire the suite into CI before the lint step: cache the pinned `whitaker-installer` binary and the cargo-binstall download cache, install it via `cargo binstall` with a build-from-source fallback for runners without binstall, and run `whitaker-installer` to provision the suite. The repository does not use the Cranelift backend, so the default installer invocation suffices. The suite (v0.2.5) reports no findings on this codebase, so no code changes were required. Part of the estate-wide Whitaker rollout; see leynos/netsuke#410 for the reference adoption.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59e6aadb72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace inline `${{ env.WHITAKER_INSTALLER_VERSION }}` interpolation in the
run block with the plain shell variable `"${WHITAKER_INSTALLER_VERSION}"`;
the job-level `env:` already exports it, and zizmor flags run-block template
interpolation as a template-injection hazard. Add `--locked` to the
cargo-binstall invocation so that binstall's compile fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This pull request adopts the Whitaker Dylint suite (v0.2.5) as part of the estate-wide rollout, following the reference adoption in leynos/netsuke#410.
The Makefile previously invoked
whitakeronly when it happened to be on thePATH, silently skipping the suite otherwise. The lint gate now treats the suite as mandatory: aWHITAKER ?= whitakertool variable sits alongside the other tool variables, and thelintrecipe runs the suite after Clippy with warnings denied, reusing the repository's existingRUST_FLAGSandCARGO_FLAGSconventions. CI provisions the suite before the lint step by caching and installing the pinnedwhitaker-installerbinary, with a build-from-source fallback for runners that lackcargo binstall. The repository does not use the Cranelift backend, so the default installer invocation suffices.The suite reported no findings against this codebase, so no code fixes or
dylint.tomlexclusions were required.Review walkthrough
Makefile: adds theWHITAKERtool variable, replaces the skip-if-absent invocation with a mandatory run after Clippy, and updates thelinthelp text to mention Whitaker..github/workflows/ci.yml: adds theWHITAKER_INSTALLER_VERSIONjob environment variable, a cache step for the installer binary and the cargo-binstall cache, and an install step (binstall with a crates.io build fallback) that runswhitaker-installerbeforemake lint.Validation
All gates were run from the repository root with the stray
WHITAKERenvironment variable unset (env -u WHITAKER):make check-fmt— passmake lint— pass (cargo doc, Clippy, and the Whitaker suite all clean)make typecheck— passmake test— pass (18/18 via nextest; doc tests clean)make markdownlint— pass (27 files, 0 errors)make nixie— passmake assets-checkandmake manifest-check— passwhitaker --all -- --all-targets --all-featureswithRUSTFLAGS="-D warnings"— exit 0, no findingsThe Python tests under
tests/have no declared pytest dependency inpyproject.toml(a pre-existing condition unrelated to this change), so they were not exercised.