Install Whitaker from the released installer in generated CI - #56
Conversation
Replace the git-revision `cargo install` of `whitaker-installer` in the template's generated CI workflow with the released 0.2.5 crate fetched via `cargo binstall`, matching the estate-standard adoption pattern (see leynos/netsuke#410). The `--cranelift` flag is retained because generated projects build with the Cranelift debug backend. The cache key moves to `whitaker-v3-<os>-<version>` so stale rev-keyed caches are not reused, and the tooling contract now asserts the new installation log line.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 58 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad1c75a5e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add `--locked` to the cargo-binstall invocation in the generated CI workflow
so that binstall's compile fallback resolves dependencies from the published
lockfile, keeping fallback builds reproducible. Replace the inline
`${{ steps.cache-whitaker.outputs.cache-hit }}` interpolation in the run
block with an env-mapped shell variable, matching the shell-variable
indirection zizmor expects for run-block template expressions. Refresh the
syrupy snapshot for the rendered workflow.
Summary
This branch aligns the template's generated CI with the estate-standard Whitaker installation pattern used in leynos/netsuke#410 and the tier 1–2 rollout. The generated workflow previously built
whitaker-installerfrom a pinned git revision; it now installs the released 0.2.5 crate viacargo binstall, keeping the--craneliftflag because generated projects use the Cranelift debug backend. Projects rendered from this template therefore pick up the maintained release channel instead of a fixed commit.Review walkthrough
WHITAKER_INSTALLER_REVenvironment variable becomesWHITAKER_INSTALLER_VERSION: '0.2.5', the cache key moves towhitaker-v3-…so stale rev-keyed caches are ignored, and the install step uses the guardedcargo binstall.Validation
make test(render, compilation, lint-target, contract, and snapshot suites): 50 passed, 1 xfailed.WITH_ACT=1 make test(act-validation suite against a Podman socket, act v0.2.80): 50 passed, 1 xfailed.Notes
The template's
linttarget and Makefile Whitaker resolution are unchanged; only the installation channel in the generated CI moves to the released crate.