Skip to content

Install Whitaker from the released installer in generated CI - #56

Merged
leynos merged 2 commits into
mainfrom
adopt-whitaker
Jul 9, 2026
Merged

Install Whitaker from the released installer in generated CI#56
leynos merged 2 commits into
mainfrom
adopt-whitaker

Conversation

@leynos

@leynos leynos commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

This branch aligns the template's generated CI with the estate-standard Whitaker installation pattern used in leynos/netsuke#410 and the tier 1–2 rollout. The generated workflow previously built whitaker-installer from a pinned git revision; it now installs the released 0.2.5 crate via cargo binstall, keeping the --cranelift flag because generated projects use the Cranelift debug backend. Projects rendered from this template therefore pick up the maintained release channel instead of a fixed commit.

Review walkthrough

Validation

  • make test (render, compilation, lint-target, contract, and snapshot suites): 50 passed, 1 xfailed.
  • WITH_ACT=1 make test (act-validation suite against a Podman socket, act v0.2.80): 50 passed, 1 xfailed.

Notes

The template's lint target and Makefile Whitaker resolution are unchanged; only the installation channel in the generated CI moves to the released crate.

Replace the git-revision `cargo install` of `whitaker-installer` in the
template's generated CI workflow with the released 0.2.5 crate fetched
via `cargo binstall`, matching the estate-standard adoption pattern
(see leynos/netsuke#410). The `--cranelift` flag is retained because
generated projects build with the Cranelift debug backend.

The cache key moves to `whitaker-v3-<os>-<version>` so stale
rev-keyed caches are not reused, and the tooling contract now asserts
the new installation log line.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 58 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d80b2ead-7ee2-4261-b551-993ffbfd995b

📥 Commits

Reviewing files that changed from the base of the PR and between 7d7eb00 and fac2539.

📒 Files selected for processing (3)
  • template/.github/workflows/ci.yml
  • tests/helpers/tooling_contracts/workflows.py
  • tests/test_template/__snapshots__/test_snapshots.ambr
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adopt-whitaker

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad1c75a5e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread template/.github/workflows/ci.yml Outdated
Add `--locked` to the cargo-binstall invocation in the generated CI workflow
so that binstall's compile fallback resolves dependencies from the published
lockfile, keeping fallback builds reproducible. Replace the inline
`${{ steps.cache-whitaker.outputs.cache-hit }}` interpolation in the run
block with an env-mapped shell variable, matching the shell-variable
indirection zizmor expects for run-block template expressions. Refresh the
syrupy snapshot for the rendered workflow.
@leynos
leynos merged commit 0b57b3e into main Jul 9, 2026
6 checks passed
@leynos
leynos deleted the adopt-whitaker branch July 9, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant