Skip to content

fix: Disabled Appearance="Primary" button renders white text on light background #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

fix: Disabled Appearance="Primary" button renders white text on light background #1701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0729082
Initial plan
Copilot Apr 30, 2026
6ffc843
fix: disabled Primary button foreground invisible on light background
Copilot Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Wpf.Ui/Controls/Button/Button.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,11 @@
<Setter Property="BorderBrush" Value="{DynamicResource AccentControlElevationBorderBrush}" />
<Setter Property="MouseOverBorderBrush" Value="{DynamicResource AccentControlElevationBorderBrush}" />
</Trigger>

<!-- DISABLED - must be last to override Appearance trigger foreground -->
<Trigger Property="IsEnabled" Value="False">
<Setter Property="Foreground" Value="{DynamicResource ButtonForegroundDisabled}" />
</Trigger>
Copy link
Copy Markdown
Contributor

@dkuaf dkuaf Apr 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be better to move the Appearance triggers to inside the ControlTemplate.Triggers and position them before the existing triggers, i tested it and it works nicely. @pomianowski can i make another PR?

</Style.Triggers>
</Style>

Expand Down
Loading