Skip to content

[Merged by Bors] - refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/LpSeminorm/Basic#38455

Closed
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:M_3
Closed

[Merged by Bors] - refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/LpSeminorm/Basic#38455
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:M_3

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • reuses eLpNorm'_mono_enorm_ae to shorten eLpNorm'_mono_nnnorm_ae
  • reuses eLpNorm_mono_enorm_ae to shorten eLpNorm_mono_nnnorm_ae
  • rewrites eLpNorm_le_of_ae_nnnorm_bound as a direct simpa from eLpNorm_le_of_ae_enorm_bound

Extracted from #38104

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 24, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 24, 2026

Benchmark results for 20d6386 against e18244a are in. No significant results found. @yuanyi-350

  • 🟥 build//instructions: +22.0G (+0.01%)

No significant changes detected.

@github-actions
Copy link
Copy Markdown

PR summary e18244a4f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label Apr 24, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • eLpNorm'_mono_nnnorm_ae: 0.053128 -> 0.020422 (-61.6%)
  • eLpNorm_mono_nnnorm_ae: 0.016148 -> 0.011026 (-31.7%)
  • eLpNorm_le_of_ae_nnnorm_bound: 0.013916 -> 0.032377 (+132.7%)

Overall:

  • eLpNorm'_mono_nnnorm_ae and eLpNorm_mono_nnnorm_ae are faster.
  • eLpNorm_le_of_ae_nnnorm_bound regresses in elaboration time.

Copy link
Copy Markdown
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 24, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
…orm/Basic` (#38455)

- reuses `eLpNorm'_mono_enorm_ae` to shorten `eLpNorm'_mono_nnnorm_ae`
- reuses `eLpNorm_mono_enorm_ae` to shorten `eLpNorm_mono_nnnorm_ae`
- rewrites `eLpNorm_le_of_ae_nnnorm_bound` as a direct `simpa` from `eLpNorm_le_of_ae_enorm_bound`

Extracted from #38104

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 24, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/LpSeminorm/Basic [Merged by Bors] - refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/LpSeminorm/Basic Apr 24, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants