Skip to content

[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/LegendreSymbol/GaussEisensteinLemmas#38402

Closed
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:N_6
Closed

[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/LegendreSymbol/GaussEisensteinLemmas#38402
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:N_6

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • golfs GaussEisensteinLemmas by replacing a manual prod_bij_ne_one argument with Finset.prod_ite
  • closes the resulting product identity directly with simp

Extracted from #38144

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

PR summary dd46575852

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Apr 23, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • gauss_lemma_aux₁: 1.712065 -> 1.115671 (-34.8%)

Overall:

  • gauss_lemma_aux₁ elaborates faster after replacing the manual prod_bij_ne_one argument with Finset.prod_ite and simp.

@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 23, 2026

Benchmark results for 96eb16d against dd46575 are in. No significant results found. @yuanyi-350

  • build//instructions: -9.8G (-0.01%)

Small changes (1✅)

  • build/module/Mathlib.NumberTheory.LegendreSymbol.GaussEisensteinLemmas//instructions: -2.1G (-6.56%)

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by MichaelStollBayreuth.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 24, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 24, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
…ssEisensteinLemmas` (#38402)

- golfs `GaussEisensteinLemmas` by replacing a manual `prod_bij_ne_one` argument with `Finset.prod_ite`
- closes the resulting product identity directly with `simp`

Extracted from #38144

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 24, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(NumberTheory): golf Mathlib/NumberTheory/LegendreSymbol/GaussEisensteinLemmas [Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/LegendreSymbol/GaussEisensteinLemmas Apr 24, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants