[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/ADEInequality#38351
Closed
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/ADEInequality#38351yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Mathlib/NumberTheory/ADEInequality#38351yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
yuanyi-350
added
codex
12 tasks
PR summary ee3a5404e5Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.This script lives in the
|
github-actions
Bot
added
the
t-number-theory
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
|
yuanyi-350
changed the title
ADEInequalityMathlib/NumberTheory/ADEInequality
Collaborator
Author
|
!bench |
|
Benchmark results for 8169369 against ee3a540 are in. No significant results found. @yuanyi-350
Small changes (1🟥)
|
tb65536
approved these changes
Apr 23, 2026
Contributor
tb65536
left a comment
tb65536
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by tb65536. |
mathlib-triage
Bot
added
the
maintainer-merge
Member
|
Thanks! bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
…8351) - golfs `ADEInequality` by replacing repeated `inv_le_inv₀` proof blocks with direct applications of `inv_anti₀` - shortens `lt_three`, `lt_four`, and `lt_six` by removing the now-unneeded fixed-denominator positivity witnesses Extracted from #38144 [](https://gitpod.io/from-referrer/)
](https://gitpod.io/from-referrer/){kind=link}
mathlib-triage
Bot
added
ready-to-merge
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
Bot
changed the title
Mathlib/NumberTheory/ADEInequalityMathlib/NumberTheory/ADEInequality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADEInequalityby replacing repeatedinv_le_inv₀proof blocks with direct applications ofinv_anti₀lt_three,lt_four, andlt_sixby removing the now-unneeded fixed-denominator positivity witnessesExtracted from #38144