Skip to content

Tag absolute value lemmas with @[push]#38321

Draft
ldct wants to merge 1 commit intoleanprover-community:masterfrom
ldct:ldct-push-abs
Draft

Tag absolute value lemmas with @[push]#38321
ldct wants to merge 1 commit intoleanprover-community:masterfrom
ldct:ldct-push-abs

Conversation

@ldct
Copy link
Copy Markdown
Collaborator

@ldct ldct commented Apr 21, 2026

Summary

  • Tag abs_mul, abs_pow, abs_mul_self, abs_inv, abs_div, abs_zpow, and abs_neg with @[push] so that push abs can distribute absolute value through arithmetic expressions.
  • Add tests in MathlibTest/push.lean including a compound example: |a ^ n * b⁻¹ / (-a)| = |a| ^ n * |b|⁻¹ / |a|

Test plan

  • lake env lean MathlibTest/push.lean passes
  • CI

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

PR summary 98261a9c88

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 21, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 21, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant