Skip to content

feat(GRewrite): new grw implementation#38318

Draft
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-grw-2
Draft

feat(GRewrite): new grw implementation#38318
JovanGerb wants to merge 1 commit intoleanprover-community:masterfrom
JovanGerb:Jovan-grw-2

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

An implementation of grw that does it's own congruence loop, instead of relying on the gcongr tactic to make the proof. This can rewrite terms with binders.


Open in Gitpod

@JovanGerb JovanGerb marked this pull request as draft April 20, 2026 22:44
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2026

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@github-actions
Copy link
Copy Markdown

PR summary cc26c21489

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Tactic.GRewrite.SinglePass (new file) 77

Declarations diff

+ GRewriteLemma
+ GRewriteLemma.getValue
+ GRewriteM
+ _root_.Lean.MVarId.grewriteImp
+ applyGCongrLemma
+ biSup_inf_le
+ elabGRewrite
+ elabGRewriteLemma
+ evalGRewriteSeq'
+ ge_imp_ge_of_le_of_le
+ grewriteLocalDecl'
+ grewriteTarget'
+ gt_imp_gt_of_le_of_le
- _root_.Lean.MVarId.applyWithArity

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant