Skip to content

chore: make RingHom.comp implicit_reducible#38315

Draft
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_red
Draft

chore: make RingHom.comp implicit_reducible#38315
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_red

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor


Open in Gitpod

@sgouezel sgouezel marked this pull request as draft April 20, 2026 20:56
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2026

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@github-actions
Copy link
Copy Markdown

PR summary 79540a76d4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 20, 2026
@github-actions
Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

error: the PR title does not contain a colon
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@sgouezel sgouezel changed the title try chore: make RingHom.comp implicit_reducible Apr 21, 2026
@sgouezel
Copy link
Copy Markdown
Contributor Author

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 21, 2026

Benchmark results for 64837c4 against 79540a7 are in. There are significant results. @sgouezel

  • build//instructions: -136.9G (-0.08%)

Large changes (1✅)

  • build/module/Mathlib.Algebra.Category.CommAlgCat.Monoidal//instructions: -83.2G (-33.18%)

Medium changes (2✅)

  • build/module/Mathlib.Algebra.Category.BialgCat.Monoidal//instructions: -11.6G (-17.72%)
  • build/module/Mathlib.AlgebraicGeometry.GammaSpecAdjunction//instructions: -5.7G (-5.84%)

Small changes (11✅, 3🟥)

  • 🟥 build/module/Mathlib.Algebra.Ring.TransferInstance//instructions: +243.4M (+2.34%)
  • build/module/Mathlib.AlgebraicGeometry.SpreadingOut//instructions: -609.1M (-2.19%)
  • build/module/Mathlib.AlgebraicGeometry.ValuativeCriterion//instructions: -672.1M (-2.78%)
  • 🟥 build/module/Mathlib.Data.Matrix.Auto//instructions: +134.0M (+3.60%)
  • build/module/Mathlib.FieldTheory.CardinalEmb//instructions: -2.3G (-1.87%)
  • build/module/Mathlib.FieldTheory.Extension//instructions: -2.3G (-3.05%)
  • build/module/Mathlib.Geometry.RingedSpace.LocallyRingedSpace.HasColimits//instructions: -916.7M (-3.41%)
  • build/module/Mathlib.RingTheory.Bialgebra.Hom//instructions: -782.2M (-2.79%)
  • build/module/Mathlib.RingTheory.Etale.QuasiFinite//instructions: -9.3G (-3.19%)
  • build/module/Mathlib.RingTheory.GradedAlgebra.AlgHom//instructions: -966.2M (-3.30%)
  • build/module/Mathlib.RingTheory.TensorProduct.Maps//instructions: -9.1G (-4.69%)
  • build/module/Mathlib.RingTheory.WittVector.IsPoly//instructions: -647.3M (-2.35%)
  • build/module/Mathlib.Tactic.Linarith//instructions: -297.4M (-6.51%)
  • 🟥 build/module/Mathlib.Tactic.MinImports//instructions: +132.1M (+2.63%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants