Skip to content

chore(LinearAlgebra/Matrix): deprecate Matrix.star_mul#38307

Open
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Vierkantor:Matrix.star_mul-docstring
Open

chore(LinearAlgebra/Matrix): deprecate Matrix.star_mul#38307
Vierkantor wants to merge 1 commit intoleanprover-community:masterfrom
Vierkantor:Matrix.star_mul-docstring

Conversation

@Vierkantor
Copy link
Copy Markdown
Contributor

This PR generalizes the Matrix.starMul instance so that Matrix.star_mul can be replaced with star_mul from the root namespace. I verified the two are exactly the same (after this generalization) by with_reducible rfl. I noticed this while looking at docstrings.


Open in Gitpod

This PR generalizes the `Matrix.starMul` instance so that `Matrix.star_mul` can be replaced with `star_mul` from the root namespace. I verified the two are exactly the same (after this generalization) by `with_reducible rfl`. I noticed this [while looking at docstrings](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60star_mul.60.20is.20a.20version.20of.20.60star_mul.60.20for.20.60.2A.60.20instead.20of.20.60.2A.60/with/587815164).
@Vierkantor Vierkantor added easy < 20s of review time. See the lifecycle page for guidelines. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown

PR summary cc26c21489

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance [Fintype n] [NonUnitalNonAssocSemiring α] [StarRing α] : StarRing (Matrix n n α)
- instance [Fintype n] [NonUnitalSemiring α] [StarRing α] : StarRing (Matrix n n α)

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 20, 2026
Comment thread Mathlib/LinearAlgebra/Matrix/ConjTranspose.lean
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 20, 2026
@j-loreaux
Copy link
Copy Markdown
Contributor

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2026

Merge conflict.

Merge or rebase master into this PR and resolve the conflict, then someone with permission can run bors r+ or bors retry.

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 20, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 20, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants