Skip to content

[Merged by Bors] - chore: fix implicit-reducible diamonds in elliptic curves#38306

Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintEllCurve
Closed

[Merged by Bors] - chore: fix implicit-reducible diamonds in elliptic curves#38306
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintEllCurve

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

The following fails on master, works with the PR:

example :
(WeierstrassCurve.Affine.CoordinateRing.instAlgebra.toSMul : SMul R
W'.CoordinateRing) =
    AdjoinRoot.instSMulAdjoinRoot W'.polynomial := by
  with_reducible_and_instances rfl

Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary cc26c21489

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : Algebra R W'.CoordinateRing := inferInstance
+ instance : Algebra R[X] W'.CoordinateRing := inferInstance
+ instance : IsScalarTower R R[X] W'.CoordinateRing := inferInstance
- instance : Algebra R W'.CoordinateRing
- instance : Algebra R[X] W'.CoordinateRing
- instance : IsScalarTower R R[X] W'.CoordinateRing

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebraic-geometry Algebraic geometry label Apr 20, 2026
@kbuzzard
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 20, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 20, 2026
The following fails on master, works with the PR:
```lean
example :
(WeierstrassCurve.Affine.CoordinateRing.instAlgebra.toSMul : SMul R
W'.CoordinateRing) =
    AdjoinRoot.instSMulAdjoinRoot W'.polynomial := by
  with_reducible_and_instances rfl
```

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix implicit-reducible diamonds in elliptic curves [Merged by Bors] - chore: fix implicit-reducible diamonds in elliptic curves Apr 20, 2026
@mathlib-bors mathlib-bors bot closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants