[Merged by Bors] - chore: fix implicit-reducible diamonds in Primrec#38305
Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: fix implicit-reducible diamonds in Primrec#38305sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary cc26c21489Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
t-computability
kbuzzard
reviewed
Apr 20, 2026
| theorem vector_toList_iff {n} {f : α → List.Vector β n} : | ||
| (Primrec fun a => (f a).toList) ↔ Primrec f := | ||
| subtype_val_iff | ||
| subtype_val_iff (hp := (@Primrec.eq ℕ _).comp list_length (const _)) |
Member
There was a problem hiding this comment.
This one is a little disappointing. Are we missing some API or something?
Contributor
Author
There was a problem hiding this comment.
I don't think so. The whole API was relying on defeq abuse, hoping that hp would be somehow embedded in an instance. It's not any more the case when we break the defeq abuse, so we have to give this argument that it couldn't guess otherwise -- but it makes sense.
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
The following examples fail on master, work with the PR:
```lean
example : (Primcodable.ulower.toEncodable : Encodable (ULower α)) =
instEncodableULower := by
with_reducible_and_instances rfl
```
```lean
example : (Primcodable.vector.toEncodable : Encodable (List.Vector
α n)) =
Encodable.List.Vector.encodable := by
with_reducible_and_instances rfl
```
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following examples fail on master, work with the PR: