Skip to content

[Merged by Bors] - chore: fix double instance declaration in FiniteAdeleRing#38300

Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintAdele
Closed

[Merged by Bors] - chore: fix double instance declaration in FiniteAdeleRing#38300
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintAdele

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

FiniteAdeleRing has two DFunLike instance, defeq but not reducibly so, where the first one is not nice, and the second one is nice but with a proof using the first one. Instead, we give directly the nice instance with a direct proof.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary cc26c21489

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- instance : DFunLike (FiniteAdeleRing R K) (HeightOneSpectrum R) (fun v ↦ v.adicCompletion K)

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Apr 20, 2026
@kbuzzard
Copy link
Copy Markdown
Member

Looks like this was my bad in #32277 -- thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 20, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 20, 2026
`FiniteAdeleRing` has two `DFunLike` instance, defeq but not reducibly so, where the first one is not nice, and the second one is nice but with a proof using the first one. Instead, we give directly the nice instance with a direct proof.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix double instance declaration in FiniteAdeleRing [Merged by Bors] - chore: fix double instance declaration in FiniteAdeleRing Apr 20, 2026
@mathlib-bors mathlib-bors bot closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants