[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/Cyclotomic/Basic#38280
Closed
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/Cyclotomic/Basic#38280yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Mathlib/NumberTheory/Cyclotomic/Basic#38280yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
yuanyi-350
added
codex
PR summary 4fceb4697eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
Bot
added
the
t-number-theory
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
|
14 tasks
acmepjz
reviewed
Apr 20, 2026
Collaborator
acmepjz
left a comment
acmepjz
left a comment
There was a problem hiding this comment.
Thank you! Looks like a great simplicifation.
tb65536
approved these changes
Apr 21, 2026
Contributor
tb65536
left a comment
tb65536
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by tb65536. |
mathlib-triage
Bot
added
the
maintainer-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
…38280) - refactors `Cyclotomic/Basic` by rewriting `nonempty_algEquiv_adjoin_of_isSepClosed` around `AlgHom.fieldRange_eq_map` and `IntermediateField.adjoin_map` - replaces the manual adjoin induction with direct `adjoin_le_iff` inclusions for the cyclotomic roots Extracted from #38144 , migrate from #38202 [](https://gitpod.io/from-referrer/)
](https://gitpod.io/from-referrer/){kind=link}
mathlib-triage
Bot
added
ready-to-merge
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Mathlib/NumberTheory/Cyclotomic/BasicMathlib/NumberTheory/Cyclotomic/Basic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cyclotomic/Basicby rewritingnonempty_algEquiv_adjoin_of_isSepClosedaroundAlgHom.fieldRange_eq_mapandIntermediateField.adjoin_mapadjoin_le_iffinclusions for the cyclotomic rootsExtracted from #38144 , migrate from #38202