Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Mathlib/NumberTheory/NumberField/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,8 @@ lemma mk_eq_mk (x y : K) (hx hy) : (⟨x, hx⟩ : 𝓞 K) = ⟨y, hy⟩ ↔ x =

/-- The ring homomorphism `(𝓞 K) →+* (𝓞 L)` given by restricting a ring homomorphism
`f : K →+* L` to `𝓞 K`. -/
def mapRingHom {K L : Type*} [Field K] [Field L] (f : K →+* L) : (𝓞 K) →+* (𝓞 L) where
toFun k := ⟨f k.val, map_isIntegral_int f k.2⟩
map_zero' := by ext; simp only [map_mk, map_zero]
map_one' := by ext; simp only [map_mk, map_one]
map_add' x y := by ext; simp only [map_mk, map_add]
map_mul' x y := by ext; simp only [map_mk, map_mul]
def mapRingHom {K L : Type*} [Field K] [Field L] (f : K →+* L) : (𝓞 K) →+* (𝓞 L) :=
f.toIntAlgHom.mapIntegralClosure.toRingHom

@[simp]
theorem mapRingHom_apply {K L : Type*} [Field K] [Field L] (f : K →+* L) (x : 𝓞 K) :
Expand Down
1 change: 1 addition & 0 deletions Mathlib/NumberTheory/NumberField/CMField.lean
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ theorem regOfFamily_realFunSystem :
show f.symm w = (equivInfinitePlace K).symm w.1 by rfl,
show algebraMap (𝓞 K) K _ = algebraMap K⁺ K _ by rfl, equivInfinitePlace_symm_apply]
simp [f, g]
congr
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumberField.RingOfIntegers.mapRingHom is not used anywhere else, so it is very strange that changing its definition affects the proof here.


theorem regulator_div_regulator_eq_two_pow_mul_indexRealUnits_inv :
regulator K / regulator K⁺ = 2 ^ rank K * (indexRealUnits K : ℝ)⁻¹ := by
Expand Down
Loading