Skip to content

[Merged by Bors] - refactor(Analysis): golf Mathlib/Analysis/SpecialFunctions/Gamma/Basic#38273

Closed
yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
yuanyi-350:A_2
Closed

[Merged by Bors] - refactor(Analysis): golf Mathlib/Analysis/SpecialFunctions/Gamma/Basic#38273
yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
yuanyi-350:A_2

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

@yuanyi-350 yuanyi-350 commented Apr 20, 2026

  • rewrites Gamma_eq_integral using Complex.GammaIntegral_ofReal instead of an inline set-integral congruence

Extracted from #37968, migrated from #38076.

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

PR summary c3e588b468

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6533 -1 backward.isDefEq.respectTransparency

Current commit 5c09b5fa98
Reference commit c3e588b468

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Apr 20, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

yuanyi-350 commented Apr 20, 2026

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • Real.Gamma_eq_integral: 0.271334 -> 0.024531 (-91.0%)

Overall:

  • Both changed declarations are faster.

Comment thread Mathlib/Analysis/SpecialFunctions/Gamma/Basic.lean Outdated
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 21, 2026
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 21, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 21, 2026
…ic` (#38273)

- rewrites `Gamma_eq_integral` using `Complex.GammaIntegral_ofReal` instead of an inline set-integral congruence
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 21, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(Analysis): golf Mathlib/Analysis/SpecialFunctions/Gamma/Basic [Merged by Bors] - refactor(Analysis): golf Mathlib/Analysis/SpecialFunctions/Gamma/Basic Apr 21, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 21, 2026
@yuanyi-350 yuanyi-350 deleted the A_2 branch April 24, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants