Skip to content

[Merged by Bors] - chore: fix an implicit-reducible diamond in subfields#38247

Closed
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintSubfield
Closed

[Merged by Bors] - chore: fix an implicit-reducible diamond in subfields#38247
sgouezel wants to merge 1 commit intoleanprover-community:masterfrom
sgouezel:SG_lintSubfield

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 0f22cd1449

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 19, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 19, 2026

Benchmark results for 1903dba against 0f22cd1 are in. There are significant results. @riccardobrasca

  • build//instructions: -13.5G (-0.01%)

Large changes (1✅)

  • build/module/Mathlib.FieldTheory.Relrank//instructions: -20.0G (-19.71%)

Small changes (1✅, 2🟥)

  • 🟥 build/module/Mathlib.CategoryTheory.Category.Pairwise//instructions: +427.5M (+3.53%)
  • build/module/Mathlib.Tactic.Linarith//instructions: -274.7M (-6.05%)
  • 🟥 build/module/Mathlib.Tactic.MinImports//instructions: +131.4M (+2.62%)

@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 19, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 19, 2026
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 19, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: fix an implicit-reducible diamond in subfields [Merged by Bors] - chore: fix an implicit-reducible diamond in subfields Apr 19, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants