chore(Tactic/Linter): unicode linter documentation improvements#38019
chore(Tactic/Linter): unicode linter documentation improvements#38019adomasbaliuka wants to merge 5 commits intoleanprover-community:masterfrom
Conversation
PR summary 00dbc4ec64Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
left a comment
There was a problem hiding this comment.
I would have expected a link to the webpage, but the rendered link on github looks pretty enough. Thanks!
bors d+
The new order seems more logical and would also improve performance (which probably doesn't matter) since Mathlib has more characters in otherInMathlib than emojis
|
I made some more doc changes. @grunweg Sorry for the question but how can I look at the modified website? Do I have to clone https://github.com/leanprover-community/mathlib4_docs and build locally? |
|
I almost never look at the modified website: the webpages are essentially markdown (so it's mostly clear how it will look), that how I get by. Do you need to do so for your PR? |
|
The other changes looks good to me. Can you update the PR description accordingly? (Otherwise, feel free to mark your PR as ready for review and merge it yourself.) |
|
Mainly I just thought I should know how to build the docs. Also, I should check what it looks like at some point as part of "testing" my changes. But if it's hard, I can also wait until it's actually merged and check then. Thanks! |
|
bors merge |
|
🔒 Permission denied Existing reviewers: click here to make adomasbaliuka a reviewer |
|
Ah, you mean mathlib's docs! Same answer, I guess. |
|
bors merge |
As planned in #36773, we add a link to the style guide, which was updated at leanprover-community/leanprover-community.github.io#820. Further changes: - some more documentation updates (some obsolete comments were talking about a "blocklist" which no longer exists) - change order of checks in `isAllowedCharacter`. The new order is more logical and may slightly improve performance (which probably doesn't matter) since Mathlib has more characters in `otherInMathlib` than `emojis`.
As planned in #36773, we add a link to the style guide, which was updated at leanprover-community/leanprover-community.github.io#820.
Further changes:
isAllowedCharacter. The new order is more logical and may slightly improve performance (which probably doesn't matter) since Mathlib has more characters inotherInMathlibthanemojis.I linked to the file in the GitHub repo, not the website, so people can immediately edit the content when needed.